Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt CAConstants for HIon #34811

Closed
wants to merge 547 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
547 commits
Select commit Hold shift + click to select a range
953b652
added plugins/.cc files
smuzaffar Aug 12, 2021
0585f8d
Coderule script: fixes needed for python3
smuzaffar Aug 12, 2021
16ea397
Modify material budget code relevant to study XML vs DB
Aug 12, 2021
eaae007
Modified the examination of geometry in XML and DB
Aug 12, 2021
c17a6fd
Code check
Aug 12, 2021
0ffb54b
Code check
Aug 12, 2021
8c588de
initialize Trackster::iterationIndex_
slava77 Aug 12, 2021
39cdfb8
Merge pull request #34855 from smuzaffar/coderule-py3
cmsbuild Aug 13, 2021
11eae5b
Merge pull request #34849 from smuzaffar/SimCalorimetry-fix-hdr
cmsbuild Aug 13, 2021
9eefac4
Merge pull request #34842 from bsunanda/Run3-sim100
cmsbuild Aug 13, 2021
405e624
Merge pull request #34826 from smuzaffar/boost-regex
cmsbuild Aug 13, 2021
b8480c7
Merge pull request #34852 from iarspider/patch-3
cmsbuild Aug 13, 2021
baa8248
Merge pull request #34832 from mmusich/sistripCommmissioningRunsDQM_1…
cmsbuild Aug 13, 2021
0d1b269
Merge pull request #34771 from Dr15Jones/fixHeadersMaker
cmsbuild Aug 13, 2021
5eb483c
Merge pull request #34837 from Dr15Jones/fasterMonitorElementData_Pat…
cmsbuild Aug 13, 2021
ad16ad4
Merge pull request #34856 from bsunanda/Run3-gex87
cmsbuild Aug 13, 2021
9c6edd7
Header Consistency
lecriste Aug 13, 2021
ec592a3
fixing wrong key for the histogram
yeckang Aug 13, 2021
f824ae8
[DQM] Remove unnecessary include statements to avoid private header dep
smuzaffar Aug 13, 2021
52036b2
[L1TTrackMatch] Remove unnecessary include statements to avoid privat…
smuzaffar Aug 13, 2021
560dc61
Propagate review comments
lecriste Aug 13, 2021
ec21aba
[RecoMuon] Remove unnecessary include statements to avoid private hdr…
smuzaffar Aug 13, 2021
590354a
[Reco] Removed unnecessary include statements
smuzaffar Aug 13, 2021
14d66e9
[Reco] Removed unnecessary include statements
smuzaffar Aug 13, 2021
4b18baa
[RecoPixelVertexing] Move public headers to interface directory
smuzaffar Aug 13, 2021
4a6209c
Merge pull request #34857 from bsunanda/Run3-sim101
cmsbuild Aug 13, 2021
a12d430
[RecoTracker] Move public headers to interface directory
smuzaffar Aug 13, 2021
3b2a195
added interface/getBestVertex.h
smuzaffar Aug 13, 2021
e346f3f
Add missing include in CondDBTools.cc
iarspider Aug 13, 2021
8f254b2
[TkTrackingRegions] Move public headers to interface directory
smuzaffar Aug 13, 2021
3cbb3a1
Update PhotonConversionTrajectorySeedProducerFromSingleLegAlgo.h
smuzaffar Aug 13, 2021
1952e8a
[Validation] Removed unnecessary include statements
smuzaffar Aug 13, 2021
8f7b497
[IOMC] Move public headers to interface directory
smuzaffar Aug 13, 2021
b39668b
Merge pull request #34829 from bsunanda/Run3-alca196
cmsbuild Aug 13, 2021
429a58d
Merge pull request #34833 from perrotta/removeDeadAssignments
cmsbuild Aug 13, 2021
d432d0f
Merge pull request #34862 from smuzaffar/dqm-hdr-cleanup
cmsbuild Aug 13, 2021
8742487
Merge pull request #34844 from CTPPS/pps-alignment-global-fix
cmsbuild Aug 13, 2021
1644d7b
Merge pull request #34869 from iarspider/patch-8
cmsbuild Aug 13, 2021
9a9b99a
[DBG] Fixes needed for 08-12-2300 DBG IB
smuzaffar Aug 13, 2021
306ad3d
more Python3 fixes for geometry script
kpedro88 Aug 13, 2021
db6ca68
fix miscelleanous mistakes in the all-in-one template configutations
mmusich Aug 13, 2021
2543ada
introduce python compilation time check of the configuration files pr…
mmusich Aug 13, 2021
3e7e962
Make P5 as the default for 2021 scenarios
Aug 13, 2021
3de4e2b
code-format
smuzaffar Aug 13, 2021
3637c2c
Merge pull request #34871 from smuzaffar/Validation-hdr-fix
cmsbuild Aug 14, 2021
86657f8
Merge pull request #34870 from smuzaffar/TkTrackingRegions-hdr-fix
cmsbuild Aug 14, 2021
7b0bce5
Merge pull request #34868 from smuzaffar/RecoTracker-hdr-fix
cmsbuild Aug 14, 2021
0ce49c4
Merge pull request #34867 from smuzaffar/RecoPixelVertexing-hdr-fix
cmsbuild Aug 14, 2021
9ab5533
Merge pull request #34864 from smuzaffar/RecoMuon-fix-hdr
cmsbuild Aug 14, 2021
7b0f8cd
Merge pull request #34828 from mteroerd/ape_plots_and_bug_fix
cmsbuild Aug 14, 2021
e45b01a
Merge pull request #34759 from ChrisMisan/from-CMSSW_12_0_0_pre2
cmsbuild Aug 14, 2021
fcdc6dd
removed obsolete classes
jshlee Jul 31, 2021
2898fd8
code-checks
jshlee Aug 11, 2021
cbd7131
Merge pull request #34876 from mmusich/miscellaneousFixesAlignmentOff…
cmsbuild Aug 15, 2021
aeec555
Merge pull request #34853 from smuzaffar/CalibMuon-merge-plugin
cmsbuild Aug 15, 2021
913c7fe
Merge pull request #34821 from yeckang/gemValid_12_0_0_pre3
cmsbuild Aug 15, 2021
07b7c6f
Merge pull request #34505 from UniMiBAnalyses/BiancaPinolini-Ecal-rec…
cmsbuild Aug 15, 2021
57911e2
make type fully consistent, avoid magic number
kpedro88 Aug 15, 2021
341d7b6
Merge pull request #34800 from lecriste/SimTS_fromAnyCP
cmsbuild Aug 15, 2021
e387347
modernize LhcTrackAnalyzer
mmusich Aug 14, 2021
a040c9b
Restore separation between hits calibration and validation
lecriste Aug 15, 2021
dabcb2b
Remove duplictaed hardcoded label 'simClusters'
lecriste Aug 15, 2021
e615e39
Remove duplictaed hardcoded label 'ClusterLevel'
lecriste Aug 15, 2021
4ee3da5
Put P4 in the list of depricated class
Aug 15, 2021
7322d80
Merge pull request #34809 from guitargeek/deps_1
cmsbuild Aug 16, 2021
28dbc9f
Merge pull request #34881 from mmusich/modernizeLhcTrackAnalyzer
cmsbuild Aug 16, 2021
f87a446
Update RecoLocalCalo/HGCalRecProducers/plugins/HeterogeneousHGCalHEFC…
smuzaffar Aug 16, 2021
f24ac41
Merge pull request #34875 from kpedro88/Phase2-WF74
cmsbuild Aug 16, 2021
2a91998
Buildfile cleanup: remove non-existing module.cc file
smuzaffar Aug 16, 2021
a7f22d3
migrate AlignmentProducer to event consumes
mmusich Aug 16, 2021
bd636b9
Merge pull request #34879 from bsunanda/Run3-gex88
cmsbuild Aug 16, 2021
7e54fe9
BuildFile: use py3-qlalchemy
smuzaffar Aug 16, 2021
0e575a9
Merge pull request #34874 from smuzaffar/dbg-fix210812
cmsbuild Aug 16, 2021
8b8d820
Merge pull request #34846 from OzAmram/TemplateInterpolate_isFinite_f…
cmsbuild Aug 16, 2021
cac746c
Fix typo for skiped
tvami Aug 16, 2021
ebe1492
Remove duplictaed hardcoded label 'hgcalLayerClusters'
lecriste Aug 15, 2021
5d62c0c
[CommonTools] Move public headers in to interface directory
smuzaffar Aug 16, 2021
09235cd
Merge pull request #34886 from smuzaffar/condtools-py3-qlalchemy
cmsbuild Aug 16, 2021
1b6b965
[Generator] Move public headers in to interface directory
smuzaffar Aug 16, 2021
51ca82e
[Fireworks] Move public headers in to interface directory
smuzaffar Aug 16, 2021
8897abe
[Calib] Move private header in to src directory
smuzaffar Aug 16, 2021
7280fe5
Added ThreadHandoff class
Dr15Jones Aug 16, 2021
e51cf0d
Run G4 worker on its own dedicated thread
Dr15Jones Aug 16, 2021
aa64686
applied code format
Dr15Jones Aug 16, 2021
12c1f60
Removed thread_local from RunManagerMTWorker
Dr15Jones Aug 16, 2021
e058dfb
Be able to set worker thread stack size in configuration
Dr15Jones Aug 16, 2021
a70edbc
do not produce NaNs in SiPixelActionExecutor
mmusich Aug 16, 2021
d979696
Merge pull request #34892 from tvami/CosmeticFixRelMons
cmsbuild Aug 16, 2021
76d36a5
Merge pull request #34883 from smuzaffar/SimG4CMS-bf-cleanup
cmsbuild Aug 16, 2021
5846a81
Merge pull request #34897 from smuzaffar/calib-hdr-fix0816
cmsbuild Aug 16, 2021
08216ce
Merge pull request #34896 from smuzaffar/fireworks-hdr-fix0816
cmsbuild Aug 17, 2021
93c52a8
Merge pull request #34697 from Dr15Jones/FWCoreFramework_task_chains
cmsbuild Aug 17, 2021
fa08891
[GCC10] Use constexpr which fixes gcc10 build error
smuzaffar Aug 17, 2021
18a5f98
Merge pull request #34900 from mmusich/fixWf8.0comparisons
cmsbuild Aug 17, 2021
b50f20a
Read ROOT files for Seed BDTs (newly converted from XML files)
bainbrid Aug 17, 2021
964253e
Merge pull request #34834 from jeongeun/recoTauTag12X
cmsbuild Aug 17, 2021
f663843
[Validation] Move EcalDigis sources in to plugins dir
smuzaffar Aug 17, 2021
81a2941
[Validation] USe correct header for ParametersDefinerForTP
smuzaffar Aug 17, 2021
c7ba375
Merge pull request #34903 from smuzaffar/gcc10-build-fix
cmsbuild Aug 17, 2021
973fb0f
Complete migration of TrackClassifier to esConsumes()
makortel Aug 17, 2021
2269f3c
[Geometry] Move public headers in to interface dir
smuzaffar Aug 17, 2021
bae3189
code-format
smuzaffar Aug 17, 2021
ccc53be
Created setupSiteLocalConfig
Dr15Jones Aug 17, 2021
0839674
make makeHGCalValidationPlots.py executable again
apsallid Aug 17, 2021
4f25489
Moved headers from src to interface in FWCore/Framework
Dr15Jones Aug 16, 2021
9df0e0c
[HLTriggerOffline] Move Higgs sources in to plugins dir
smuzaffar Aug 17, 2021
753ed62
[PhysicsTools] Move icc file used by public interface in to interface…
smuzaffar Aug 17, 2021
bb5bf39
Set random number system in worker thread
Dr15Jones Aug 17, 2021
63d0988
new environment variable used to instruct source to start from a
smorovic Aug 17, 2021
5e1bfed
Merge pull request #34909 from apsallid/makeexeagain
cmsbuild Aug 17, 2021
911121d
Parallelize SimpleValidation
lecriste Aug 17, 2021
73ba792
Consolidated GLBMuonAnalyzer into one file
Dr15Jones Aug 17, 2021
574cf23
Merge pull request #34894 from smuzaffar/Generator-hdr-fix0816
cmsbuild Aug 17, 2021
28a90ec
Move Guid.h to interface
Dr15Jones Aug 17, 2021
f613a65
[Reco] Fixes needed to avoid exposing private headers via interface dir
smuzaffar Aug 17, 2021
de357eb
Merge pull request #34893 from smuzaffar/CommonTools-fix-hdr
cmsbuild Aug 17, 2021
8ae5e4f
Add HCAL tag HcalRespCorrs_2021_v3.0_mc
tvami Aug 17, 2021
1acfa67
Migrate (Cosmic)ParametersDefinerForTP to esConsumes()
makortel Aug 17, 2021
1628e94
Remove unnecessary dependencies to boost and root
makortel Aug 17, 2021
ca6091c
Merge pull request #34915 from Dr15Jones/setupSiteLocalConfig
cmsbuild Aug 17, 2021
68b243c
Merge pull request #34891 from Dr15Jones/moreHeaderMovesFWCoreFramework
cmsbuild Aug 17, 2021
6e354d2
Merge pull request #34905 from smuzaffar/validation-correct-hdr0817
cmsbuild Aug 17, 2021
dd0eb10
Merge pull request #34911 from smuzaffar/HLTriggerOffline-hdr-fix0817
cmsbuild Aug 17, 2021
b03f7f6
Merge pull request #34916 from Dr15Jones/moveGuid
cmsbuild Aug 17, 2021
191fd1a
Merge pull request #34912 from smorovic/120X-daq-start-from-ls
cmsbuild Aug 17, 2021
ea0b9d0
Merge pull request #34710 from colizz/dev-121X-enableConcurrentGen
cmsbuild Aug 17, 2021
bec4911
Merge pull request #34858 from slava77/patch-102
cmsbuild Aug 17, 2021
67da130
Merge pull request #34866 from smuzaffar/reco1-hdr-cleanup
cmsbuild Aug 17, 2021
75859ae
Attempt to define unqiue names of materials everywhere
Aug 17, 2021
5150abf
Migrate SeedingLayerSetsBuilder to esConsumes()
makortel Aug 17, 2021
d5e92da
Correct the cfg's so that they can work
Aug 17, 2021
44853c7
Merge pull request #34913 from smuzaffar/PhysicsTools-hdr-fix0817
cmsbuild Aug 18, 2021
e19ec19
Merge pull request #34863 from smuzaffar/L1TTrackMatch-hdr-fix
cmsbuild Aug 18, 2021
0b6eae2
Fix radix sort test
fwyzard Aug 18, 2021
4389d9c
included MessageLogger.h LogDebug
smuzaffar Aug 18, 2021
4d8a07c
Merge pull request #34928 from bsunanda/Run3-sim102
cmsbuild Aug 18, 2021
e777a47
Merge pull request #34907 from smuzaffar/geom-hdr-fix0817
cmsbuild Aug 18, 2021
80c9d7e
Merge pull request #34910 from makortel/esconsumesTrackClassifier
cmsbuild Aug 18, 2021
e571303
rename a file correctly
Aug 18, 2021
05c2b42
Merge pull request #34929 from fwyzard/fix_radix_sort_test_121x
cmsbuild Aug 18, 2021
261a9d8
Merge pull request #34865 from smuzaffar/reco-hdr-cleanup
cmsbuild Aug 18, 2021
4011a22
Simplify setting EDPutTokenT via call to produces
Dr15Jones Aug 17, 2021
294a387
Merge pull request #34767 from iarspider/patch-6
cmsbuild Aug 18, 2021
21e8ba0
cleanup self include
smuzaffar Aug 18, 2021
385517c
Migrate PFTauPrimaryVertexProducerBase to esConsumes()
makortel Aug 18, 2021
ec693cf
remove self include
smuzaffar Aug 18, 2021
49904c5
Resolve compilation problem with clang
Dr15Jones Aug 18, 2021
7c5f4bd
Migrate PFSimParticleProducer to esConsumes()
makortel Aug 18, 2021
5dd73cf
Reaarange the files to remove .h files from SimCalorimetry/CastorSim/src
Aug 18, 2021
089e39a
Merge pull request #34924 from makortel/esconsumesParametersDefinerTP
cmsbuild Aug 18, 2021
bbdfbaf
Reaarange the files to remove .h files from SimCalorimetry/HcalSimPro…
Aug 18, 2021
9be29e8
Better reporting of CPU timing
Dr15Jones Aug 18, 2021
456c93a
Migrate PixelInactiveAreaFinder to esConsumes()
makortel Aug 18, 2021
fc189b2
Migrate DeepCoreSeedGenerator to esConsumes()
makortel Aug 18, 2021
8ef951d
Migrate OutsideInMuonSeeder to esConsumes()
makortel Aug 18, 2021
811d01c
Migrate SimpleCosmicBONSeeder to esConsumes()
makortel Aug 18, 2021
341026a
Migrate CosmicTrackFinder to esConsumes()
makortel Aug 18, 2021
1ae51eb
Migrate MeasurementTrackerEventProducer to esConsumes()
makortel Aug 18, 2021
71633d7
Remove unnecessary default constructor of SeedingLayerSetsBuilder
makortel Aug 18, 2021
f389b3e
Remove MuonToSimAssociatorBase and MuonToSimAssociatorByHits as obsolete
makortel Aug 17, 2021
b19bdaa
Remove TrackAssociatorRecord as obsolete
makortel Aug 17, 2021
d9b234b
removed commented out code
Dr15Jones Aug 19, 2021
24046ab
Merge pull request #34843 from jshlee/GEM-unpacker-cleanup-CMSSW_12_1…
cmsbuild Aug 19, 2021
5da88e0
Merge pull request #34885 from mmusich/Alignment/CommonAlignmentProdu…
cmsbuild Aug 19, 2021
6827de0
Merge pull request #34899 from Dr15Jones/omtWorkerThread
cmsbuild Aug 19, 2021
0c1fafc
Merge pull request #34904 from smuzaffar/validation-hdr-fix0817
cmsbuild Aug 19, 2021
43765e2
Merge pull request #34872 from smuzaffar/IOMC-hdr-fix
cmsbuild Aug 19, 2021
1d940d4
Extend the cms::cuda::ScopedSetDevice interface
fwyzard Aug 19, 2021
097fe4a
Fix uploading the EventSetup conditions to multiple CUDA devices
fwyzard Aug 19, 2021
59b48e6
fix typo in the gen fragment file name
mtosi Aug 19, 2021
4c39ebc
Swap x and y labels for a trigger plot in ECAL DQM
abhih1 Aug 19, 2021
08be725
Remove unnecessary initialization
lecriste Aug 19, 2021
464593e
Merge pull request #34941 from Dr15Jones/betterCPUtiming
cmsbuild Aug 19, 2021
8fc59df
Migrate JetMuonHitsIDHelper to esConsumes()
makortel Aug 19, 2021
4be9049
Merge pull request #34914 from Dr15Jones/GLBMuonAnalyzer
cmsbuild Aug 19, 2021
88685fe
HLT customisation for Patatrack pixel tracks and GPU offload
fwyzard Aug 19, 2021
b5b03e2
Merge pull request #34908 from bainbrid/LowPtElectrons_SeedBDTs_XMLTo…
cmsbuild Aug 19, 2021
3bba44c
Migrate PileupJetIdProducer to esConsumes()
makortel Aug 19, 2021
2fdd16d
Merge pull request #34951 from mtosi/fixBuJPsiPrimeK
cmsbuild Aug 19, 2021
e5ed64c
Add public interface for constructing and freeing caching allocators
makortel Aug 19, 2021
a8460d4
Migrate QGTragger to esConsumes
makortel Aug 19, 2021
e9f1ee4
Avoid bare 'new' in QGTagger
makortel Aug 19, 2021
78b1f35
Migrate CSCHaloAlgo to esConsumes()
makortel Aug 18, 2021
563a157
Migrate PFMETAlgorithmMVA to esConsumes()
makortel Aug 18, 2021
7982f76
Migrate PFMETProducer to esConsumes()
makortel Aug 18, 2021
ca6b4b5
Migrate EEBadScFilter to esConsumes()
makortel Aug 18, 2021
69f88b8
Migrate EcalBadCalibFilter to esConsumes()
makortel Aug 18, 2021
5f1eefb
Migrate EcalDeadCellBoundaryEnergyFilter to esConsumes()
makortel Aug 19, 2021
022f847
Migrate EcalLaserCorrFilter to esConsumes()
makortel Aug 19, 2021
600914b
Migrate JetTracksAssociatorAtCaloFace to esConsumes()
makortel Aug 19, 2021
aad8037
Migrate TrackExtrapolator to esConsumes()
makortel Aug 19, 2021
633b0cc
Migrate HIPixelClusterVtxProducer to esConsumes()
makortel Aug 19, 2021
95fe82c
Merge pull request #34953 from abhih1/ChangeTrigPlotLabel_Master
cmsbuild Aug 19, 2021
d653ec0
Merge pull request #34948 from fwyzard/CUDA_fix_concurrent_EventSetup…
cmsbuild Aug 19, 2021
27c82ba
Merge pull request #34954 from lecriste/parallelValidation
cmsbuild Aug 19, 2021
f047520
Strip topolgy for sub-classes of StripTopology was not exported.
osschar Aug 19, 2021
1d0a1dc
Migrate HIProtoTrackFilterProducer to esConsumes()
makortel Aug 19, 2021
c2b6d8a
clang format
osschar Aug 19, 2021
122ac18
Migrate HiEvtPlaneFlatProducer and EvtPlaneProducer to esConsumes()
makortel Aug 20, 2021
0cf2db6
Migrate HiEgammaSCCorrectionMaker to esConsumes()
makortel Aug 20, 2021
e845efb
Migrate HiSpikeCleaner to esConsumes()
makortel Aug 20, 2021
99a06ec
Remove useless try-catch's from HiSpikeCleaner
makortel Aug 20, 2021
5e57437
fix header guard and use full include path
smuzaffar Aug 20, 2021
8facb74
initialize TrackstersProducer::iterIndex_ to 0
slava77 Aug 20, 2021
bf54420
cast
slava77 Aug 20, 2021
69d2c87
Merge pull request #34956 from fwyzard/HLT_customisation_for_GPU_121x
cmsbuild Aug 20, 2021
43b5d8c
Take care of Andrea's comments
Aug 20, 2021
775ef2e
Take care of Andrea's comments
Aug 20, 2021
4604233
Changes to fix ESConsumes
abhih1 Aug 20, 2021
cc4865c
Merge pull request #34919 from smuzaffar/reco-hdr-fix0817
cmsbuild Aug 20, 2021
4d1fcde
Fix code style
abhih1 Aug 20, 2021
b04428b
Add tools to study big xml file which goes in the D
Aug 20, 2021
87e056e
Corrected comments
Dr15Jones Aug 20, 2021
828d42d
Migrate TrackTimeValueMapProducer to esConsumes()
makortel Aug 20, 2021
89e2b64
Merge pull request #34958 from makortel/cachingAllocatorHeader
cmsbuild Aug 20, 2021
6cec14e
Migrate TrackAssociatorByChi2Producer to esConsumes()
makortel Aug 20, 2021
a2e2af6
Migrate TrackAssociatorByHitsProducer to esConsumes()
makortel Aug 20, 2021
d5ae1d4
Migrate TrackAssociatorByPositionProducer to esConsumes()
makortel Aug 20, 2021
49126d6
Restore cms::cuda::ESProduct construction without GPU
makortel Aug 20, 2021
b0f8547
Migrate TrackingParticleNumberOfLayersProducer to esConsumes()
makortel Aug 20, 2021
1db891a
Merge pull request #34939 from bsunanda/Run3-hcx308
cmsbuild Aug 20, 2021
03b6c53
Merge pull request #34940 from bsunanda/Run3-hcx309
cmsbuild Aug 20, 2021
86bd3d5
Merge pull request #34960 from osschar/from-CMSSW_12_1_X_2021-08-18-1500
cmsbuild Aug 20, 2021
076def7
Some changes made for testing big xml from DDD
Aug 20, 2021
ec08c83
Add cfg's for DDD Big XML
Aug 20, 2021
85ec07f
Merge pull request #34935 from makortel/esconsumesRecoTauTag
cmsbuild Aug 21, 2021
102fc73
Merge pull request #34938 from makortel/esconsumesRecoParticleFlow
cmsbuild Aug 21, 2021
9d768fa
Merge pull request #34959 from makortel/esconsumesRecoJets
cmsbuild Aug 21, 2021
b6bdfd8
Merge pull request #34961 from makortel/esconsumesRecoHI
cmsbuild Aug 21, 2021
d47b94b
Merge pull request #34926 from Dr15Jones/simpler_produces
cmsbuild Aug 21, 2021
0202948
Merge pull request #34943 from makortel/esconsumesRecoMET
cmsbuild Aug 21, 2021
58edc28
Merge pull request #34934 from makortel/esconsumesRecoTrack
cmsbuild Aug 21, 2021
c07daee
Merge pull request #34944 from makortel/cleanupTrackAssociatorRecord
cmsbuild Aug 21, 2021
8124e8c
Merge pull request #34962 from slava77/patch-103
cmsbuild Aug 21, 2021
cca242c
Merge pull request #34967 from makortel/esconsumesSimTracker
cmsbuild Aug 21, 2021
da69ccd
Merge pull request #34969 from makortel/esconsumesTrackingParticleNum…
cmsbuild Aug 21, 2021
f546286
Migrate RPCRecHitProducer to esConsumes()
makortel Aug 19, 2021
2b0205b
Merge pull request #34968 from makortel/cudaESProductWithoutGPU
cmsbuild Aug 21, 2021
fea5cc2
Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src
Aug 21, 2021
3edf2a8
Merge pull request #34972 from bsunanda/Run3-hcx310
cmsbuild Aug 22, 2021
e3cfc78
Merge pull request #34927 from bsunanda/Run3-gex89
cmsbuild Aug 23, 2021
399ed27
Merge pull request #34964 from bsunanda/Run3-sim103
cmsbuild Aug 23, 2021
efb9321
Fix legacy module inherit warning
abhih1 Aug 23, 2021
639404c
Merge pull request #34945 from makortel/esconsumesRPCRecHitProducer
cmsbuild Aug 23, 2021
f16f6ef
Avoid memory overwrites in Ecal PayloadInspectors
Dr15Jones Aug 23, 2021
b12e587
Merge pull request #34963 from abhih1/ESConsumesFixDBModule_master
cmsbuild Aug 23, 2021
150bed4
Merge pull request #34922 from tvami/FixHCALrespAssymetry
cmsbuild Aug 23, 2021
df77a76
Merge pull request #34982 from Dr15Jones/fixEcalPayloadInspectors
cmsbuild Aug 23, 2021
1ddf537
Merged CMSSW_12_1_X_GPU_HIon_v1 from repository stahlleiton with cms-…
Aug 24, 2021
0b491a1
Updated the maxCellsPerHit threshold
Aug 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 0 additions & 3 deletions Alignment/APEEstimation/plugins/ApeEstimatorSummary.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1077,9 +1077,6 @@ void ApeEstimatorSummary::analyze(const edm::Event& iEvent, const edm::EventSetu
for (auto& i_sector : m_tkSector_) {
delete a_sectorName[i_sector.first];
}
delete sectorNameTree;
delete defaultTreeX;
delete defaultTreeY;
}

firstEvent = false;
Expand Down
12 changes: 12 additions & 0 deletions Alignment/APEEstimation/python/AlignmentTrackSelector_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@
trackQualities = ["highPurity"],
)

## Filter for cosmics tracks
NoPuritySelector = Alignment.CommonAlignmentProducer.AlignmentTrackSelector_cfi.AlignmentTrackSelector.clone(
applyBasicCuts = True,
filter = True,
src = 'ALCARECOTkAlMuonIsolated',
etaMin = -999.,
etaMax = 999.,
)

##
## Filters for skims
##
genSimSkimSelector = Alignment.CommonAlignmentProducer.AlignmentTrackSelector_cfi.AlignmentTrackSelector.clone(
applyBasicCuts = True,
filter = True,
Expand Down
9 changes: 8 additions & 1 deletion Alignment/APEEstimation/python/TrackRefitter_38T_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
HighPuritySelector = Alignment.APEEstimation.AlignmentTrackSelector_cff.HighPuritySelector
HighPuritySelector.src = 'MuSkim'


NoPuritySelector = Alignment.APEEstimation.AlignmentTrackSelector_cff.NoPuritySelector
NoPuritySelector.src = 'MuSkim'

## SEQUENCE

Expand All @@ -33,5 +34,11 @@
TrackRefitterForApeEstimator
)

RefitterNoPuritySequence = cms.Sequence(
offlineBeamSpot*
NoPuritySelector*
TrackRefitterForApeEstimator
)



10 changes: 8 additions & 2 deletions Alignment/APEEstimation/test/autoSubmitter/autoSubmitter.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ def __init__(self, config, name):
self.sampleType = "MC"
else:
self.sampleType ="data1"

if "isCosmics" in dsDict:
self.isCosmics = (dsDict["isCosmics"] == "True")
else:
self.isCosmics = False

self.conditions, dummy, self.validConditions = loadConditions(dsDict)

Expand Down Expand Up @@ -205,7 +210,7 @@ def submit_jobs(self):

lastIter = (self.curIteration==self.maxIterations) and not self.alignment.isDesign

inputCommands = "sample={sample} fileNumber={fileNo} iterNumber={iterNo} lastIter={lastIter} alignRcd={alignRcd} maxEvents={maxEvents} globalTag={globalTag} measurementName={name} conditions={conditions}".format(sample=self.dataset.sampleType,fileNo="$1",iterNo=self.curIteration,lastIter=lastIter,alignRcd=alignmentNameToUse, maxEvents=self.maxEvents, globalTag=self.alignment.globalTag, name=self.name, conditions=rawFileName)
inputCommands = "sample={sample} fileNumber={fileNo} iterNumber={iterNo} lastIter={lastIter} alignRcd={alignRcd} maxEvents={maxEvents} globalTag={globalTag} measurementName={name} conditions={conditions} cosmics={cosmics}".format(sample=self.dataset.sampleType,fileNo="$1",iterNo=self.curIteration,lastIter=lastIter,alignRcd=alignmentNameToUse, maxEvents=self.maxEvents, globalTag=self.alignment.globalTag, name=self.name, conditions=rawFileName,cosmics=self.dataset.isCosmics)

from autoSubmitterTemplates import condorJobTemplate
jobFileContent = condorJobTemplate.format(base=base, inputFile="$2", inputCommands=inputCommands)
Expand Down Expand Up @@ -434,9 +439,10 @@ def run_iteration(self):
try:
self.submit_jobs()
save("measurements", measurements)
except:
except Exception as e:
# this is needed in case the scheduler goes down
print("Error submitting jobs for APE measurement {}".format(self.name))
print(e)
return

if self.status == STATE_BJOBS_WAITING:
Expand Down
2 changes: 2 additions & 0 deletions Alignment/APEEstimation/test/autoSubmitter/config.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ fileNames=filename.root otherFile_[1-6,8,10]_[1-2].root
maxEvents=-1
# optional, set to True for MC samples, False by default
isMC=False
# optional, set to True for cosmics samples, False by default
isCosmics=False

#define alignments like this
[alignment:alignmentObject]
Expand Down
20 changes: 13 additions & 7 deletions Alignment/APEEstimation/test/cfgTemplate/apeEstimator_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
options.register('lastIter', False, VarParsing.VarParsing.multiplicity.singleton, VarParsing.VarParsing.varType.bool, "Last iteration")
options.register('alignRcd','', VarParsing.VarParsing.multiplicity.singleton, VarParsing.VarParsing.varType.string, "AlignmentRcd")
options.register('conditions',"None", VarParsing.VarParsing.multiplicity.singleton, VarParsing.VarParsing.varType.string, "File with conditions")

options.register('cosmics', False, VarParsing.VarParsing.multiplicity.singleton, VarParsing.VarParsing.varType.bool, "Cosmic data set")
# get and parse the command line arguments
options.parseArguments()

Expand Down Expand Up @@ -194,7 +194,6 @@
)
)
process.es_prefer_trackerAlignmentErr = cms.ESPrefer("PoolDBESSource","myTrackerAlignmentErr")



##
Expand Down Expand Up @@ -253,11 +252,18 @@
##
## Path
##
process.p = cms.Path(
#process.TriggerSelectionSequence* # You want to use this if you want to select for triggers
process.RefitterHighPuritySequence*
process.ApeEstimatorSequence
)

if not options.cosmics:
process.p = cms.Path(
#process.TriggerSelectionSequence* # You want to use this if you want to select for triggers
process.RefitterHighPuritySequence*
process.ApeEstimatorSequence
)
else:
process.p = cms.Path(
process.RefitterNoPuritySequence* # this sequence doesn't include high purity track criteria
process.ApeEstimatorSequence
)



2 changes: 1 addition & 1 deletion Alignment/APEEstimation/test/plottingTools/drawResults.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
plot.setOutputPath(base+"/hists/workingArea/")
# label(also used as name when adding systematic errors), inputFile, color (optional, automatic by default),
# marker (optional, 20 by default, 0 is line), hitNumbers (optional, file number of hits in each sector, allData.root)
plot.addInputFile("label", "base/hists/workingArea/iter14/allData_iterationApe.root", color = ROOT.kGray+2)
plot.addInputFile("label", base+"/hists/workingArea/iter14/allData_iterationApe.root", color = ROOT.kGray+2)
plot.setGranularity(standardGranularity)
plot.draw()
21 changes: 21 additions & 0 deletions Alignment/APEEstimation/test/plottingTools/drawValidation.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Implementation to draw results of an APE measurement
# to check convergence
from validationPlotter import *
from granularity import *
import ROOT
import os
try:
base = os.environ['CMSSW_BASE']+"/src/Alignment/APEEstimation"
except KeyError:
base = ""

plot = ValidationPlotter()
plot.setOutputPath(base+"/hists/workingArea/validation")
# label(also used as name when adding systematic errors), inputFile, color (optional, automatic by default),
# marker (optional, 20 by default, 0 is line)
# Multiple inputs possible, in which case the plots will be normalized
# Remember that the folder has to be either iter0 or iter15 or baseline
plot.addInputFile("mp3401", "{base}/hists/workingArea/iter15/allData.root".format(base=base),color=ROOT.kBlack)
plot.addInputFile("Design", "{base}/hists/Design/baseline/allData.root".format(base=base),color=ROOT.kRed,marker=0)
plot.setGranularity(standardGranularity)
plot.draw()
18 changes: 9 additions & 9 deletions Alignment/APEEstimation/test/plottingTools/resultPlotter.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ def makeHitNumbers(self, label, sectorRange, coordinate):
posX = (float(i)+0.5)/numSectors*(1-ROOT.gPad.GetLeftMargin()-ROOT.gPad.GetRightMargin())+ROOT.gPad.GetLeftMargin()
posY = (1-ROOT.gPad.GetTopMargin()-size)-1.2*size*self.numHitCounters

label = ROOT.TLatex(posX, posY, "%.2E"%(num))
label.SetNDC(True)
label.SetTextColor(self.colors[label])
label.SetTextSize(size)
label.SetTextFont(font)
label.SetTextAngle(45)
label.SetTextAlign(align)
labels.append(label)
labelTex = ROOT.TLatex(posX, posY, "%.2E"%(num))
labelTex.SetNDC(True)
labelTex.SetTextColor(self.colors[label])
labelTex.SetTextSize(size)
labelTex.SetTextFont(font)
labelTex.SetTextAngle(45)
labelTex.SetTextAlign(align)
labels.append(labelTex)
return labels

def makeHist(self, label, sectorRange, coordinate, number):
Expand Down Expand Up @@ -161,7 +161,7 @@ def draw(self):
plotNumber = 0
rangeList = self.granularity.sectors[coordinate]
for sectorRange in rangeList:
self.canvas = ROOT.TCanvas("canvas", "canvas", int(ROOT.gStyle.GetCanvasDefW()*len(list(range(sectorRange[0],sectorRange[1]+1)))/10.),ROOT.gStyle.GetCanvasDefH())
self.canvas = ROOT.TCanvas("canvas", "canvas", max(int(ROOT.gStyle.GetCanvasDefW()*len(list(range(sectorRange[0],sectorRange[1]+1)))/10.), int(ROOT.gStyle.GetCanvasDefW()/2)),ROOT.gStyle.GetCanvasDefH())
ROOT.gPad.SetRightMargin(0.10)

legend = ROOT.TLegend(0.2,0.62,0.5,0.82)
Expand Down
Loading