Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional paths to customizeHLTIter0ToMkFit #34793

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The other paths also include hltIter0PFlowCkfTrackCandidates and need the change in order to be self-consistent.
The inconsistency was found by #34735

PR validation:

I ran workflow 11634.7 with this change and the changes from #34735 and it now runs fine.

The other paths also include hltIter0PFlowCkfTrackCandidates and
need the change in order to be self-consistent.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34793/24501

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • RecoTracker/MkFit (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

code-checks

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2021

it looks like the bot is out for lunch or dinner

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2021

it looks like the bot is out for lunch or dinner

@smuzaffar
please take a look, to get the bot to react to code-checks

@smuzaffar
Copy link
Contributor

@slava77 , most of code check jobs run on lxplus nodes and for last few days we have issues with some of lxplus nodes where singularity can not run [a]. Unfortunately code checks for this PR was run 4 times on buggy nodes.

Anyway, code checks are running now and results will be available soon

singularity -s exec /cvmfs/unpacked.cern.ch/registry.hub.docker.com/cmssw/cc7:amd64 sh -c 'export ORIGINAL_SINGULARITY_BIND=${SINGULARITY_BIND}; export SINGULARITY_BIND='\'''\'';  source /cvmfs/cms.cern.ch/cmsset_default.sh ; export PATH=$PATH:/usr/sbin;export PATH=$HOME/bin:$PATH; voms-proxy-init -voms cms -valid 24:00|| true ; cd /tmp/cmsbuild/jenkins/workspace/run-pr-code-checks; echo $PATH; /tmp/cmsbuild/jenkins/workspace/run-pr-code-checks/run.sh'
00:26:01 �[91mERROR  : Failed to create user namespace: user namespace disabled

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34793/24536

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

Pull request #34793 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

@smuzaffar is the comparison test for this pr stuck in some endless loop? Seems to be doing the same thing over and over for the past 12 hours.

@smuzaffar
Copy link
Contributor

@Dr15Jones not really, https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/44643/ should finish in 10/20 mins. Normally it takes 2 hours when job starts.

@Dr15Jones
Copy link
Contributor Author

@smuzaffar I checked this build before going to bed last night and the camparison had already been running for more than 2 hours. I then get up this morning and it still says it is running.

@smuzaffar
Copy link
Contributor

Here is the sequence of jobs

all look good in terms of jobs. As jenkins was very busy last night that is why there were delays beteween various jobs

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-235cd6/17599/summary.html
COMMIT: a297db5
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34793/17599/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999410
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999381
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Aug 6, 2021

+reconstruction

for #34793 a297db5

  • code changes are in line with the PR description and the follow up review
  • jenkins tests pass; the specific fail case targeted by this PR was tested as detailed in the PR description

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 7, 2021

+1

@cmsbuild cmsbuild merged commit 49b6d8f into cms-sw:master Aug 7, 2021
@Dr15Jones Dr15Jones deleted the addMissingPathsTo_customizeHLTIter0ToMkFit branch August 9, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants