Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herwig6 header files from non-interace, related to #34718 #34792

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

theofil
Copy link
Contributor

@theofil theofil commented Aug 5, 2021

PR description:

This is related to #34718

The header GeneratorInterface/Herwig6Interface/src/hwudat.f was moved to GeneratorInterface/Herwig6Interface/interface/hwudat.f

Created GeneratorInterface/Herwig6Interface/src/hwudat.F with the following contents

#include "GeneratorInterface/Herwig6Interface/interface/hwudat.f"

Updated

GeneratorInterface/PomwigInterface/plugins/hwudat.F
GeneratorInterface/Herwig6Interface/src/hwudat.F

to include GeneratorInterface/Herwig6Interface/interface/hwudat.f

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34792/24494

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

A new Pull Request was created by @theofil (Konstantinos Theofilatos) for master.

It involves the following packages:

  • GeneratorInterface/Herwig6Interface (generators)
  • GeneratorInterface/PomwigInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d79e68/17566/summary.html
COMMIT: 44be281
CMSSW: CMSSW_12_1_X_2021-08-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34792/17566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999410
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999387
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

agrohsje commented Aug 5, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

+1

@cmsbuild cmsbuild merged commit eabbb10 into cms-sw:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants