Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning that lists legacy modules if any are configured. #34577

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Add warning that lists legacy modules if any are configured. #34577

merged 4 commits into from
Jul 27, 2021

Commits on Jul 21, 2021

  1. Convert some modules from legacy to global or one 

    These are test modules in FWCore/MessageService. When
run, the output log is compared as part of a unit test.
These unit tests fail when the new warning is added that
lists legacy modules that are configured.
    @wddgit
    wddgit committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8b4562f View commit details
    Browse the repository at this point in the history

  2. Update unit tests so they will pass 

    These unit tests compare log files and fail
when the new warning listing configured legacy
modules is added.
    @wddgit
    wddgit committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    82fc9f2 View commit details
    Browse the repository at this point in the history

  3. Add warning message with configured legacy modules

    @wddgit
    wddgit committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    673972e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Convert modules from legacy to global type 

    Also fixed a minor memory leak
    @wddgit
    wddgit committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b848186 View commit details
    Browse the repository at this point in the history