Access RunIndex from RunForOutput #34565
Conversation
This is needed to allow use of run caches in OutputModules
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34565/24102
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
| @@ -57,6 +58,10 @@ namespace edm { | |||
| Timestamp const& endTime() const { return aux_.endTime(); } | |||
| MergeableRunProductMetadata const* mergeableRunProductMetadata() const { return mergeableRunProductMetadata_; } | |||
|
|
|||
| /**\return Reusable index which can be used to separate data for different simultaneous LuminosityBlocks. | |||
There was a problem hiding this comment.
I'm confused, how does RunIndex help to differentiate LuminosityBlocks?
There was a problem hiding this comment.
It doesn't, that is a cut-n-paste error :)
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34565/24105
|
|
Pull request #34565 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-569cbf/17020/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This adds the index() method to RunForOutput. This is needed to allow use of run caches in OutputModules
PR validation:
The code compiles and does allow use of RunCache from a global OutputModule.