Use python3 in FWCore/ParameterSet unit tests #34493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmsbuild, please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34493/23965
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Unit TestsI found errors in the following unit tests: ---> test TestFWCoreFrameworkTrigBit had ERRORS ---> test TestFWCoreFrameworkDeleteEarly had ERRORS ---> test TestIntegrationSeriesOfProcesses had ERRORS ---> test testPyDevParameterSet had ERRORS and more ... RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ... |
makortel
force-pushed
the
py3FWCoreParameterSet
branch
from
c32380a to
2f66ff8
Compare
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-rejected
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34493/23977
|
|
Pull request #34493 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
|
@cmsbuild, please test |
makortel
force-pushed
the
py3FWCoreParameterSet
branch
from
2f66ff8 to
6ca99d6
Compare
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-approved
labels
|
I extended the unit test so that the earlier problem would have been caught by the test. Now this should be good to go. |
|
@cmsbuild, please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34493/23998
|
|
Pull request #34493 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a9d7b/16863/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is a continuation of #34477. It changes FWCore/ParameterSet unit tests to use python 3, and fixes all the remaining python3 issues in these tests.
Resolves #28703. Resolves cms-sw/framework-team#189.
PR validation:
Effectively tested in CMSSW_12_0_X_2021-07-12-2300 that these tests run with python 3.