Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Update visDQMUpload.py to pyhon3 #34424

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Jul 9, 2021

PR description:

This change avoids derecation warnings in python3:
visDQMUpload.py:39: DeprecationWarning: key_file, cert_file and check_hostname are deprecated, use a custom context instead.
HTTPS.init(self, host, key_file = ssl_key_file, cert_file = ssl_cert_file, **kwargs)

PR validation:

Tested locally with usual user grid certificate, I assume no issues will arise in production....

This change avoids derecation warnings in python3:
visDQMUpload.py:39: DeprecationWarning: key_file, cert_file and check_hostname are deprecated, use a custom context instead.
  HTTPS.__init__(self, host, key_file = ssl_key_file, cert_file = ssl_cert_file, **kwargs)
@jfernan2
Copy link
Contributor Author

jfernan2 commented Jul 9, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34424/23834

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

  • DQMServices/FileIO (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

smuzaffar commented Jul 9, 2021

please test
lets re-start based on latest IB

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-649b23/16652/summary.html
COMMIT: 0965076
CMSSW: CMSSW_12_0_X_2021-07-09-0800/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34424/16652/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-649b23/16652/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-649b23/16652/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786246
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786223
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 11092.333 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 1584.619 KiB Hcal/TPTask
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@slava77 , @davidlange6 , @makortel looks like #34409 has fixed the reco comparison diff ( #34424 (comment) )

@jfernan2
Copy link
Contributor Author

+1
Changes due o 34331

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 12, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants