Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2D pixel template B field warning for 0T #34390

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

OzAmram
Copy link
Contributor

@OzAmram OzAmram commented Jul 7, 2021

This is a small PR to remove the UnexpectedMagneticField warning for the 2D pixel templates on 0T. The 2D templates are never used for 0T (see here ) so there is no need to print the warning.

This addresses issue #31956.

@mmusich @tvami @ferencek @tsusa

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34390/23782

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34390/23784

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

CalibTracker/SiPixelESProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 7, 2021

@cmsbuild , please test

@mmusich
Copy link
Contributor

mmusich commented Jul 7, 2021

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Jul 7, 2021

test parameters:

  • workflows = 11634.24, 11834.24, 138.2

@mmusich
Copy link
Contributor

mmusich commented Jul 7, 2021

@cmsbuild, please test

to actually test 0T (data and MC) workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4a994/16572/summary.html
COMMIT: 148fccf
CMSSW: CMSSW_12_0_X_2021-07-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34390/16572/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d4a994/11634.24_TTbar_14TeV+2021_0T+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d4a994/11834.24_TTbar_14TeV+2021PU_0T+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoPU+HARVESTPU+Nano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d4a994/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1263 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 3674
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 2782208
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 45.707 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jul 8, 2021

As expected the message about UnexpectedMagneticFieldUsingNonIdealPixel2DTemplate which is present in the IB logs is gone in this PR logs.

@tvami
Copy link
Contributor

tvami commented Jul 8, 2021

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 8, 2021

+1

@tvami
Copy link
Contributor

tvami commented Jul 21, 2021

With Tanja we just realized that the goal of this PR has not been reached since the current data taking happens in 11_3_X , so all the CRUZET reco will have the message that we wanted to avoid. @OzAmram can you make a backport?

@OzAmram
Copy link
Contributor Author

OzAmram commented Jul 21, 2021

Ok I made the backport #34578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants