-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 2D pixel template B field warning for 0T #34390
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34390/23782
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34390/23784
|
A new Pull Request was created by @OzAmram (Oz Amram) for master. It involves the following packages: CalibTracker/SiPixelESProducers (alca) @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
@cmsbuild, please abort |
test parameters:
|
@cmsbuild, please test to actually test 0T (data and MC) workflows |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4a994/16572/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons @slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
As expected the message about |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
With Tanja we just realized that the goal of this PR has not been reached since the current data taking happens in 11_3_X , so all the CRUZET reco will have the message that we wanted to avoid. @OzAmram can you make a backport? |
Ok I made the backport #34578 |
This is a small PR to remove the UnexpectedMagneticField warning for the 2D pixel templates on 0T. The 2D templates are never used for 0T (see here ) so there is no need to print the warning.
This addresses issue #31956.
@mmusich @tvami @ferencek @tsusa