-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix definition override in RecoTrackerP5_cff.py #34332
fix definition override in RecoTrackerP5_cff.py #34332
Conversation
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34332/23694
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: RecoTracker/Configuration @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fd587/16469/summary.html Comparison SummarySummary:
|
Thank you @mmusich for the fix. After #30947 there were indeed two instances of |
yes. There are only 4 total instances of |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #30947 appears to have broken a functionality used in the tracker alignment group.
The following code snippet:
currently results in:
This PR fixes the issue reported above.
PR validation:
Run the code snippet above successfully:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, but a backport will be needed.
cc:
@DaveBrun94