Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::bind in place of boost:bind #34328

Merged
merged 19 commits into from
Jul 8, 2021

Conversation

Purva-Chaudhari
Copy link
Contributor

@Purva-Chaudhari Purva-Chaudhari commented Jul 4, 2021

PR description:

In this case we can use std::bind instead of boost::bind

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@davidlange6 @vgvassilev

@alja
Copy link
Contributor

alja commented Jul 5, 2021

+1

@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2021

+reconstruction

  • Trivial for reco: just one unneeded include removed from RecoLocalTracker/SiPixelRecHits/src/VVIObj.cc

@agrohsje
Copy link

agrohsje commented Jul 6, 2021

@Purva-Chaudhari I see in some files a change of the include but no corresponding change from boost::bind to std:bind. I assume that means the include isn't needed at all, no?

@Purva-Chaudhari
Copy link
Contributor Author

Purva-Chaudhari commented Jul 6, 2021

@Purva-Chaudhari I see in some files a change of the include but no corresponding change from boost::bind to std:bind. I assume that means the include isn't needed at all, no?

Yes! There were some unnecessary #include for boost bind. I cleaned those finding that it wasn't used.

@agrohsje
Copy link

agrohsje commented Jul 6, 2021

+generators

@makortel
Copy link
Contributor

makortel commented Jul 6, 2021

+core

@civanch
Copy link
Contributor

civanch commented Jul 6, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

@cms-sw/db-l2 Do you have any comments?

@qliphy
Copy link
Contributor

qliphy commented Jul 8, 2021

+1

@cms-sw/db-l2 let us know if you have comment.

@qliphy
Copy link
Contributor

qliphy commented Jul 8, 2021

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment