Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel Barycenters histograms in Tracker DQM [11_3_X] #34316

Merged
merged 8 commits into from
Jul 3, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 2, 2021

backport of #34312

PR description:

We added a total of nine histograms showing the coordinates of the barycenter derived by different parts of the Pixel detector. The histograms show the barycenter derived from BPIX, BPIX(x-), BPIX(x+), FPIX(z-), FPIX(z+), FPIX(z-,x-), FPIX(z-,x+), FPIX(z+,x-), FPIX(z+,x+).

PR validation:

The changes have been tested by running runTheMatrix.py -l 10024 and runTheMatrix.py -l 136.89, which run without any failed steps and produces the desired additional histograms.
Below you can see a screenshot of one of the histograms produced.

image

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #34312 (originally from @dmeuser).
cc:
@sroychow @arossi83

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

DQM/SiPixelPhase1Config
DQM/SiPixelPhase1Summary

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 2, 2021

urgent

this will be needed for CRUZET

@cmsbuild cmsbuild added the urgent label Jul 2, 2021
@mmusich
Copy link
Contributor Author

mmusich commented Jul 2, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-640733/16409/summary.html
COMMIT: 9d4462d
CMSSW: CMSSW_11_3_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34316/16409/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877861
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877838
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.202 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.554 KiB PixelPhase1/Barycenter
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 2, 2021

+1
9MEs added, no changes expected at Online DQM

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Jul 2, 2021
@qliphy
Copy link
Contributor

qliphy commented Jul 3, 2021

+1

@cmsbuild cmsbuild merged commit 6341388 into cms-sw:CMSSW_11_3_X Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants