-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx298 Correct the scripts for Geometry related to DB for HCAL #34267
Conversation
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34267/23559
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34267/23560
|
Pull request #34267 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @srimanob, @mdhildreth can you please check and sign again. |
from Geometry.HcalCommonData.hcalDBConstants_cff import * | ||
from Geometry.HcalCommonData.caloSimulationParameters_cff import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the hcalDDD*Constants_cfi needed or not? In the other above files you removed them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34267/23563
|
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34267/23571
|
Pull request #34267 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdb0a0/16280/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Correct the scripts for Geometry related to DB for HCAL
PR validation:
Use runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special