-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert to unit test in FWCore/PythonFramework to pybind11 #34217
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34217/23461
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34217/23462
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/PythonFramework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca36a1/16176/summary.html Comparison SummarySummary:
|
@davidlange6 thanks for porting it to pybind11. I think this will still fail in DEVEL and PY3 IBs as
|
yes, I think so - I'll make that change |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34217/23469
|
Pull request #34217 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca36a1/16184/summary.html Comparison SummarySummary:
|
please test for CMSSW_12_0_DEVEL_X |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca36a1/16188/summary.html Comparison SummarySummary:
|
+1 |
No description provided.