DQM: migrate modules to esConsumes

[sroychow]

PR description:

Part of #31061. This PR addresses some of the DQM modules mentioned in the static analyzer report of CMSSW_12_0_X_2021-06-20-2300.

PR validation:

Compiles and local static analyzer checks do not show Event setup get warnings.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

[qliphy]

allow @sroychow test rights

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34208/23444

• This PR adds an extra 112KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMOffline/Trigger/src/EgHLTOffHelper.cc modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

DQM/EcalPreshowerMonitorModule
DQM/GEM
DQM/L1TMonitor
DQMOffline/CalibCalo
DQMOffline/Trigger

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @jhgoh, @missirol, @rchatter, @mtosi, @watson-ij, @argiro, @calderona, @HuguesBrun, @Fedespring, @thomreis, @simonepigazzini, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

Thanks for this PR @sroychow
I see you are migrating several subsystem packages in this smae PR, could you please introduce your name and PR number in the spreadsheet to avoid duplication of work?
https://docs.google.com/spreadsheets/d/1cUypk2EK4xVcEpFGtaNqXrWZEoFz_E9l4gNN3YoBQH4/edit#gid=0
Thanks!

[sroychow]

@jfernan2 sure I plan to update the spreadsheet. I am working on a couple of more modules and then I will update it. Thanks!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34208/23455

• This PR adds an extra 120KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMOffline/Trigger/src/EgHLTOffHelper.cc modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666

[cmsbuild]

Pull request #34208 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please check and sign again.

[sroychow]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34208/23493

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMOffline/Trigger/src/EgHLTOffHelper.cc modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666

[cmsbuild]

Pull request #34208 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please check and sign again.

[sroychow]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4d844/16208/summary.html
COMMIT: dc345ce
CMSSW: CMSSW_12_0_X_2021-06-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34208/16208/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4d844/16208/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785608
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[jfernan2]

@sroychow do you plan to add more changes?

[sroychow]

@jfernan2 no. I plan to follow up others in separate PRs.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1