-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTDQM Fix to testUnit #34164
DTDQM Fix to testUnit #34164
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34164/23372
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages: DQM/DTMonitorClient @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
test parameters:
|
please test |
Why the change from single quotes to double quotes? In python those are completely equivalent. |
@@ -104,7 +104,7 @@ | |||
# Local Trigger task for test pulses | |||
from DQM.DTMonitorModule.dtTriggerTask_TP_cfi import * | |||
from DQM.DTMonitorClient.dtLocalTriggerTest_TP_cfi import * | |||
dtTPTriggerTest.hwSources = 'TM' | |||
dtTPTriggerTest.hwSources = ['TM'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two changes in this file are all that is needed to fix the unit tests.
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-157781/16070/summary.html Comparison SummarySummary:
|
This has been a misunderstanding from my side sorry... since they are equivalent I suggest taking the PR as it is |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes IB crash reported on:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_0_X_2021-06-16-2300/unitTestLogs/DQM/Integration#/
Produced by changes on #34153
PR is used to replace colon by semicolon in python files of the packages