-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Run2 data and mc GTs with JERC tags #33982
Conversation
test parameters:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33982/23086
|
A new Pull Request was created by @malbouis for master. It involves the following packages: Configuration/AlCa @yuanchao, @malbouis, @pohsun, @tlampen, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8d781/15654/summary.html Comparison SummarySummary:
|
test parameters:
|
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-pixellumi_dqm_sourceclient had ERRORS Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
I ran the unit tests locally and did not see these errors. Will retrigger the tests for the case these are transient errors. |
test parameters: workflow=136.772,136.7721,1325.516,135.1 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8d781/15725/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
hold |
Pull request has been put on hold by @francescobrivio |
unhold
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to update the Run2 data and MC GTs with the most up to date JERC tags, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4401.html
These tags were first updated in 106X (PR #33710).
Comparison between the previous GTs (in 113X) and the new ones are below:
2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_preVFP_v4/120X_mcRun2_asymptotic_preVFP_v1
2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_v4/120X_mcRun2_asymptotic_v1
Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_v6/120X_dataRun2_v1
Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_relval_v6/120X_dataRun2_relval_v1
PR validation:
runTheMatrix.py -l limited,136.772,136.7721,1325.516,135.1 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
It is not a backport.