Migrate module configurations in RecoTracker{IterativeTracking} to use default cfipython

[jeongeun]

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations.

In this PR, 6 files changed.
RecoTracker/IterativeTracking/python/ElectronSeeds_cff.py
RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py
RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py
RecoTracker/IterativeTracking/python/PixelLessStep_cff.py
RecoTracker/IterativeTracking/python/PixelPairStep_cff.py
RecoTracker/IterativeTracking/python/TobTecStep_cff.py

(The previous PRs were PR#33207, PR#33307, PR#33352, PR#33543, PR#33563, PR#33671, PR#33901)

• commit 1 : Replace explicit configuration with a reference from cfipython/. (migrating EDProducer("type", .. -> typeDefault.clone())
• commit 2 : Remove the type specifications already presented in cfipython/fillDescriptions reference for improved syntax safety.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_0_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33903/22975

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py modified in PR(s): Update MkFit to support multiple iterations #33802
  • File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): Update MkFit to support multiple iterations #33802
  • File RecoTracker/IterativeTracking/python/TobTecStep_cff.py modified in PR(s): Update MkFit to support multiple iterations #33802

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoTracker/IterativeTracking

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d88a08/15474/summary.html
COMMIT: 1530bc7
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33903/15474/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650463
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

Why this change?

[slava77]

it looks like the changes revert #33531 .
Perhaps this is a result of a not very successful rebase?

[perrotta]

I miss most of the cleanings in this file: I'm not saying they are not correct, but could you please explain the logic behind? Are all those removed modules/PSets really not needed (or replaced somehow)?

[jeongeun]

@jeongeun please redo RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py based on a recent IB. As Slava already pointed out you probably based your code changes on a IB older than CMSSW_12_0_X_2021-05-24-1100, which is when #33531 was merged.

@perrotta Thanks for your comment. I did rebase to move this branch to the recent IB (120X_06-07-2300), but it's strange that nothing different (no conflict) was found. The #33531 update was not applied properly I think.. To be clean up, I'll close this pr and recreate new one at the recent IB.

[jeongeun]

Now it updated to pr #34007.

[perrotta]

@jeongeun please redo RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py based on a recent IB. As Slava already pointed out you probably based your code changes on a IB older than CMSSW_12_0_X_2021-05-24-1100, which is when #33531 was merged.