Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MkFit to support multiple iterations #33802

Merged
merged 20 commits into from
Jun 16, 2021
Merged

Update MkFit to support multiple iterations #33802

merged 20 commits into from
Jun 16, 2021

Commits on May 6, 2021

  1. Add configuration option for duplicate removal, enable by default

    @makortel
    makortel committed May 6, 2021
    Configuration menu
    Copy the full SHA
    9b1732d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Move all geometry-related stuff to an ESProduct

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    9f31c6c View commit details
    Browse the repository at this point in the history

  2. Migrate to the updated hit interface

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    465900a View commit details
    Browse the repository at this point in the history

  3. Compute cluster charge only once, dereference Refs only once)

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    17d5077 View commit details
    Browse the repository at this point in the history

  4. A hashmap per layer is a bit faster

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    5bc1169 View commit details
    Browse the repository at this point in the history

  5. Add customize function to run mkFit on HLT

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    61f2f82 View commit details
    Browse the repository at this point in the history

  6. Split MkFitInput{Converter,Wrapper} to MkFitHit{Converter,Wrapper} an… 

    …d MkFitSeed{Converter,Wrapper}
    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    9ce4863 View commit details
    Browse the repository at this point in the history

  7. Remove support for fullVector following its removal from mkFit itself

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    5355fcd View commit details
    Browse the repository at this point in the history

  8. Fixing naming for MTV in 112X

    @mmasciov @makortel
    mmasciov authored and makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8ea9a9f View commit details
    Browse the repository at this point in the history

  9. Migrate to multi-iteration interface

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    c8b1553 View commit details
    Browse the repository at this point in the history

  10. Use mkFit in highPtTripletStep

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    6ed452a View commit details
    Browse the repository at this point in the history

  11. Add support for cluster mask, use it in HighPtTripletStep

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    9b878d5 View commit details
    Browse the repository at this point in the history

  12. Add support for cluster charge cut per iteration

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    1127f54 View commit details
    Browse the repository at this point in the history

  13. Allow switching individual iterations to mkFit, add customizations an… 

    …d enable in selected iterations
    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    7ed601f View commit details
    Browse the repository at this point in the history

  14. Add option to use task_arena limited to 1 thread

    @makortel
    makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    150feaf View commit details
    Browse the repository at this point in the history

  15. use 1D strip hits in barrel

    @cerati @makortel
    cerati authored and makortel committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    0f9bd99 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. Introduce per-iteration JSON files for mkFit configuration

    @makortel
    makortel committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    f35ccac View commit details
    Browse the repository at this point in the history

  2. Copy createCMS2017 from mkFit 

    Original names were CMS-2017.acc, CMS-2017.cc. Changes include
- Rename files to adhere CMS' naming conventions
- Adhere CMS' naming conventions
- Code format
- Replace global std::function object with a function
- Call createCMS2017 instead of ExecTrackerInfoCreatorPlugin
- Add comments on mkFit layer numbering
- Add comments on writes to global variables and on MessageLogger
    @makortel
    makortel committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    b8d4f68 View commit details
    Browse the repository at this point in the history

  3. Document configuration parameters in README 

    Co-authored-by: Mario Masciovecchio <mario.masciovecchio@cern.ch>
    @osschar @mmasciov @makortel
    2 people authored and makortel committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    27c9d22 View commit details
    Browse the repository at this point in the history

  4. Split MkFitHitProducer to MkFitSi{Pixel,Strip}HitConverter and MkFitE… 

    …ventOfHitsProducer

Pixel and strip hits are needed separately to avoid converting strip
hits again when the support for initialStepPreSplitting will
eventually be added. It also hides the question on naming (pixel vs
strip vs outer).
    @makortel
    makortel committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    78094ae View commit details
    Browse the repository at this point in the history