Allow for increased mass precision in NanoGen + increase mass precision of SUSY particles in NanoAod

[mseidel42]

PR description:

Mass precision in NanoGen was low -> increased to RECO precision, and allow for full precision

PR validation:

Ran NanoGen, checked Z mass distribution, precision looks sufficient for analysis now:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Will need backport to 10_6.

@kdlong

Update:

Increase mass precision for SUSY particles, as requested by @mariadalfonso, following HN post here: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3773.html

Change could not be tested locally, hope there is some ttbar NanoAod ouput file that we can check afterwards?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33637/22507

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

[cmsbuild]

A new Pull Request was created by @mseidel42 (Markus Seidel) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test workflow 546,547,548

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b308c4/14891/summary.html
COMMIT: 6af9fbc
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33637/14891/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b308c4/546.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b308c4/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b308c4/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2662617
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mseidel42]

Increase mass precision for SUSY particles, as requested by @mariadalfonso, following HN post here: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3773.html

Change could not be tested locally, hope there is some ttbar NanoAod ouput file that we can check afterwards?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33637/22570

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

[cmsbuild]

Pull request #33637 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

please test

[mariadalfonso]

@mseidel42 please update the title as well (it's not only nanoGEN now) and add the hn link to the PR description

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b308c4/14956/summary.html
COMMIT: 838d2bf
CMSSW: CMSSW_12_0_X_2021-05-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33637/14956/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2663139
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

nanoGen runs, and no changes in ttbar nano events (expected only on susy samples when the particle is scanned)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1