Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel local reco: reduce code duplication between SiPixelDigiErrorsFromSoA and SiPixelRawToDigi #33526

Merged
merged 19 commits into from
May 3, 2021
Merged

Pixel local reco: reduce code duplication between SiPixelDigiErrorsFromSoA and SiPixelRawToDigi #33526

merged 19 commits into from
May 3, 2021

Commits on Apr 30, 2021

  1. shorten syntax for default error list vectors

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    80db57b View commit details
    Browse the repository at this point in the history

  2. get rid of unnecessary debug variable

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    86147b1 View commit details
    Browse the repository at this point in the history

  3. remove cablingMapLabel from members

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    fee18a6 View commit details
    Browse the repository at this point in the history

  4. remove unused label

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    94a42c5 View commit details
    Browse the repository at this point in the history

  5. remove timer 

    I know it might be breaking, that's why this is an atomic commit and can be reversed easily -> git rebase
    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    363d626 View commit details
    Browse the repository at this point in the history

  6. Move unpacking of FED error collections to PixelDataFormatter

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    e3abd2b View commit details
    Browse the repository at this point in the history

  7. take errors with const reference

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    f6c459d View commit details
    Browse the repository at this point in the history

  8. remove obsolete stuff from PixelDataFormatter

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    e714478 View commit details
    Browse the repository at this point in the history

  9. use own typedefs

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    bba3554 View commit details
    Browse the repository at this point in the history

  10. apply naming convention for SiPixelRawToDigi members

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    3aafe71 View commit details
    Browse the repository at this point in the history

  11. use initializer list and make members const

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    478931c View commit details
    Browse the repository at this point in the history

  12. Use EDPutTokens in SiPixelRawData 

    - also, add Timing as an optional
- manage header includes to minimize dependency
    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    eedeaa1 View commit details
    Browse the repository at this point in the history

  13. remove Timing from HLT menus 

    extra validation: ran addOnTests.py and unittests locally
    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    ffdbb76 View commit details
    Browse the repository at this point in the history

  14. remove unused variable CheckPixelOrder

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    c147a24 View commit details
    Browse the repository at this point in the history

  15. use range-based for loop for map iteration, increase readibility 

    best c++17 feature
    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    a0ef647 View commit details
    Browse the repository at this point in the history

  16. make put token const

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    9e2a0c7 View commit details
    Browse the repository at this point in the history

  17. fix phase 1 condition

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    7c8282f View commit details
    Browse the repository at this point in the history

  18. remove header for plugin SiPixelRawToDigi

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    7e2e909 View commit details
    Browse the repository at this point in the history

  19. remove unnecessary header includes, forward declarations

    @czangela
    czangela committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    64d828b View commit details
    Browse the repository at this point in the history