Clean up tau related nanoAOD content #33513

swozniewski · 2021-04-23T10:24:00Z

PR description:

Removal of deprecated/redundant tau-related nanoAOD content.
Old decay mode ID is renamed in order to make it clearer that it is not the standard use case anymore.
Deprecated IDs are also removed from the selection which causes differences in the tau related distributions. A dR03 ID is added to the selection which adds some new taus, but altogether the number decreases.

Backport to 10_6_X for nanoAOD v9 intended.

PR validation:

Inspected some distributions by hand which change as stated above.
Code/format checks passed, unit tests passed, matrix tests passed

cmsbuild · 2021-04-23T10:30:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33513/22258

This PR adds an extra 16KB to repository

cmsbuild · 2021-04-23T10:30:57Z

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2021-04-23T14:54:46Z

please test

cmsbuild · 2021-04-23T19:00:32Z

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b82149/14547/summary.html
COMMIT: 14218f2
CMSSW: CMSSW_12_0_X_2021-04-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33513/14547/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals-INPUT

136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 107 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877046
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2877011
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-04-23T20:22:22Z

@swozniewski
please have a look

    raise ValueError(message)
ValueError: Duplicate insert of member rawAntiEle

swozniewski · 2021-04-26T08:18:05Z

I somehow missed this in the log of my local unit test. Looks like some era handling is still incorrect. I will check.

swozniewski · 2021-04-26T09:42:55Z

@mariadalfonso I'm facing some strange behaviour of the modifiers here. I verified that the failing part of the test is run with the 94XMiniAODv1 modifier (only) and it still ends up in this line https://github.com/cms-sw/cmssw/pull/33513/files#diff-d54676262d2e5326ee3455e57747fd476b12be16993a8eb0f4794e8771f6526fR161 triggering the error event though only other modifiers are used in the loop. For some reason, putting an extra check of the validity of the modifiers by hand (which in my understanding should be done by the modifiers themselves before modifying) cures the test. I put my diff below. Maybe you can verify my observation or see what the problem is.

diff --git a/PhysicsTools/NanoAOD/python/taus_cff.py b/PhysicsTools/NanoAOD/python/taus_cff.py
index ce5ebf105f6..47f1101f479 100644
--- a/PhysicsTools/NanoAOD/python/taus_cff.py
+++ b/PhysicsTools/NanoAOD/python/taus_cff.py
@@ -146,6 +146,13 @@ _variables80X =  cms.PSet(
     _mvaIsoVars2015
 )
 
+print "92X", run2_nanoAOD_92X._isChosen()
+print "94XMiniAODv1", run2_nanoAOD_94XMiniAODv1._isChosen()
+print "94XMiniAODv2", run2_nanoAOD_94XMiniAODv2._isChosen()
+print "94X2016", run2_nanoAOD_94X2016._isChosen()
+print "102Xv1",  run2_nanoAOD_102Xv1._isChosen()
+print "106Xv1", run2_nanoAOD_106Xv1._isChosen()
+
 tauTable.variables = _variablesMiniV2
 
 for era in [run2_nanoAOD_94XMiniAODv1,]:
@@ -157,6 +164,8 @@ run2_miniAOD_80XLegacy.toModify(tauTable,
 )
 for era in [run2_nanoAOD_92X, run2_nanoAOD_94XMiniAODv2, \
             run2_nanoAOD_94X2016, run2_nanoAOD_102Xv1, run2_nanoAOD_106Xv1]:
+    if not era._isChosen():
+        continue
     era.toModify(tauTable,
                  variables = cms.PSet(tauTable.variables, _mvaAntiEVars, _mvaIsoVars2015Reduced, _mvaIsoVars2017v1, _mvaIsoVars2017v2)
     )

swozniewski · 2021-04-26T09:49:49Z

ah, I guess the PSet entered as an keyword argument is created no matter whether it is used by the modifier later on and that's where it fails already...

mariadalfonso · 2021-04-26T10:54:45Z

PhysicsTools/NanoAOD/python/taus_cff.py

+for era in [run2_nanoAOD_92X, run2_nanoAOD_94XMiniAODv2, \
+            run2_nanoAOD_94X2016, run2_nanoAOD_102Xv1, run2_nanoAOD_106Xv1]:
+    era.toModify(tauTable,
+                 variables = cms.PSet(tauTable.variables, _mvaAntiEVars, _mvaIsoVars2015Reduced, _mvaIsoVars2017v1, _mvaIsoVars2017v2)
+    )


these lines are overwritten after, expect for the run2_nanoAOD_94XMiniAODv1 as is missed in this list.
also the run2_nanoAOD_94XMiniAODv1 is the one that make things crush.

Just to clarify, run2_nanoAOD_94XMiniAODv1 is not in the list on purpose because it had an independent treatment before already. See my last comment in the main thread concerning explanation and solution of the problem.

swozniewski · 2021-05-04T16:07:22Z

I added the imports of the missing modifiers and checked with one of the relval tests that failed before.

cmsbuild · 2021-05-04T16:10:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33513/22475

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add boosted taus to NanoAOD #33528, Add ParticleNet mass regression #33483

cmsbuild · 2021-05-04T16:11:13Z

Pull request #33513 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

gouskos · 2021-05-04T16:13:30Z

please test

cmsbuild · 2021-05-04T18:48:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b82149/14850/summary.html
COMMIT: 9aef44e
CMSSW: CMSSW_12_0_X_2021-05-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33513/14850/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 103 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662646
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2662617
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.612 KiB( 36 files compared)
DQMHistoSizes: changed ( 136.8523 ): -3.612 KiB Physics/NanoAODDQM
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-05-06T16:56:56Z

+xpog

major cleanup of the selection in view of UL mini run2_nanoAOD_106Xv2 and future

list of variable much more reduced now
https://cms-nanoaod-integration.web.cern.ch/integration/33513/
gain in size about 2-3%
no change to the previous eras

cmsbuild · 2021-05-06T16:57:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

mariadalfonso · 2021-05-06T17:04:15Z

@swozniewski
please prepare the backport

qliphy · 2021-05-07T00:34:31Z

+1

Sebastian Wozniewski added 2 commits April 6, 2021 15:30

clean up tau nanoAOD content

52bbb7e

fix era modification

14218f2

cmsbuild added this to the CMSSW_12_0_X milestone Apr 23, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Apr 23, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 23, 2021

swozniewski changed the title ~~Cmssw 11 3 x tau pog nano ao dclean up~~ Clean up tau related nanoAOD content Apr 23, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 23, 2021

mariadalfonso mentioned this pull request Apr 23, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild added tests-rejected and removed tests-started labels Apr 23, 2021

cmsbuild mentioned this pull request Apr 26, 2021

Change input collection for genVisTaus #33522

Merged

mariadalfonso reviewed Apr 26, 2021

View reviewed changes

avoid parameter collisions in temporary PSets

c4735ec

cmsbuild added code-checks-pending and removed code-checks-approved tests-rejected labels Apr 26, 2021

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels May 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 4, 2021

cmsbuild added tests-started and removed tests-pending labels May 4, 2021

cmsbuild mentioned this pull request May 4, 2021

update deepCore for Run3 #33531

Merged

cmsbuild added tests-approved and removed tests-started labels May 4, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels May 6, 2021

cmsbuild added orp-approved and removed orp-pending labels May 7, 2021

cmsbuild merged commit 353c5c3 into cms-sw:master May 7, 2021

swozniewski mentioned this pull request May 7, 2021

backport tau pog nanoAOD clean up to 10_6_X #33658

Merged

cmsbuild mentioned this pull request May 7, 2021

MTD geometry and reconstruction: store ETL layout logic into MTDTopology, use for ETL layers navigation in reconstruction #33598

Merged

mbluj deleted the CMSSW_11_3_X_tau-pog_nanoAODcleanUp branch October 10, 2023 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up tau related nanoAOD content #33513

Clean up tau related nanoAOD content #33513

swozniewski commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

mariadalfonso commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

mariadalfonso commented Apr 23, 2021

swozniewski commented Apr 26, 2021

swozniewski commented Apr 26, 2021

swozniewski commented Apr 26, 2021

mariadalfonso Apr 26, 2021

swozniewski Apr 26, 2021

swozniewski commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

gouskos commented May 4, 2021

cmsbuild commented May 4, 2021

mariadalfonso commented May 6, 2021

cmsbuild commented May 6, 2021

mariadalfonso commented May 6, 2021

qliphy commented May 7, 2021

Clean up tau related nanoAOD content #33513

Clean up tau related nanoAOD content #33513

Conversation

swozniewski commented Apr 23, 2021

PR description:

PR validation:

cmsbuild commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

mariadalfonso commented Apr 23, 2021

cmsbuild commented Apr 23, 2021

Unit Tests

RelVals-INPUT

Comparison Summary

mariadalfonso commented Apr 23, 2021

swozniewski commented Apr 26, 2021

swozniewski commented Apr 26, 2021

swozniewski commented Apr 26, 2021

mariadalfonso Apr 26, 2021

Choose a reason for hiding this comment

swozniewski Apr 26, 2021

Choose a reason for hiding this comment

swozniewski commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

gouskos commented May 4, 2021

cmsbuild commented May 4, 2021

Comparison Summary

mariadalfonso commented May 6, 2021

cmsbuild commented May 6, 2021

mariadalfonso commented May 6, 2021

qliphy commented May 7, 2021