Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Merged
merged 5 commits into from
May 4, 2021

Conversation

chayanit
Copy link

@chayanit chayanit commented Apr 19, 2021

This is PR to add new upgrade workflows as requested by HLT (STEAM) https://its.cern.ch/jira/browse/PDMVRELVALS-115 and Phase2 L1T https://its.cern.ch/jira/browse/PDMVRELVALS-116. All GEN fragments have been reviewing in #33409 , #33414 , #33433 and #33386. They need for Run3 validation campaign in master release and special request for Phase2 L1T.

Need for 11_3_0 so the backport is needed

@chayanit
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33461/22158

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14309/summary.html
COMMIT: 9c46010
CMSSW: CMSSW_12_0_X_2021-04-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33461/14309/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14309/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14309/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@chayanit
Copy link
Author

+1

@chayanit
Copy link
Author

please test

This PR can be merged only after all GEN fragments are merged or finalised

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33461/22427

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

Pull request #33461 was updated. @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please check and sign again.

@chayanit
Copy link
Author

chayanit commented May 3, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14799/summary.html
COMMIT: 41ea0b0
CMSSW: CMSSW_12_0_X_2021-05-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33461/14799/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14799/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14799/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2662617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@chayanit
Copy link
Author

chayanit commented May 4, 2021

+1

I would need this PR to be merged for final 11_3_0

@srimanob
Copy link
Contributor

srimanob commented May 4, 2021

I would need this PR to be merged for final 11_3_0

But this means you will need to make a backport PR, I assume.

@srimanob
Copy link
Contributor

srimanob commented May 4, 2021

+Upgrade

This PR is to add configuration in runTheMatrix. It needs to be merged together with #33407. Backport PR to 11_3_0 to be done.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@chayanit
Copy link
Author

chayanit commented May 4, 2021

Uh oh I don't know how to do the backport. What about all GEN fragments?

@srimanob
Copy link
Contributor

srimanob commented May 4, 2021

Uh oh I don't know how to do the backport. What about all GEN fragments?

GEN fragment backport is in place, #33596

How to make backport:
https://cms-sw.github.io/tutorial-resolve-conflicts.html
(looking for Backporting a PR).

@chayanit
Copy link
Author

chayanit commented May 4, 2021

There are a lot more to be backported #33409 , #33414 , #33433 and #33386 :(

@qliphy
Copy link
Contributor

qliphy commented May 4, 2021

+1

@cmsbuild cmsbuild merged commit cc65d31 into cms-sw:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants