[HGCAL] MultiCluster to CaloParticle associator

[lecriste]

PR description:

This PR introduces an associator that can be consumed by several analyzers, avoiding code duplication. This PR supersedes PR#32941, no changes are expected in the output.

PR validation:

runTheMatrix -l limited

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21983

• This PR adds an extra 204KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/ParticleFlowReco/interface/HGCalMultiCluster.h modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimCalorimetry/HGCalAssociatorProducers/interface/AssociatorTools.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366, MultiCluster-CaloParticle associator #32941
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/LayerClusterAssociatorByEnergyScoreImpl.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/MultiClusterAssociatorByEnergyScoreImpl.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/MultiClusterAssociatorByEnergyScoreImpl.h modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimCalorimetry/HGCalAssociatorProducers/plugins/MultiClusterAssociatorByEnergyScoreProducer.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimCalorimetry/HGCalAssociatorProducers/python/MCToCPAssociation_cfi.py modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/interface/MultiClusterToCaloParticleAssociator.h modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/interface/MultiClusterToCaloParticleAssociatorBaseImpl.h modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/plugins/BuildFile.xml modified in PR(s): [HGCAL] Tracksters to SimClusters associator #33333, MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/plugins/MCToCPAssociatorEDProducer.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/src/MultiClusterToCaloParticleAssociator.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/src/MultiClusterToCaloParticleAssociatorBaseImpl.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/src/classes.h modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333, MultiCluster-CaloParticle associator #32941
  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333, MultiCluster-CaloParticle associator #32941

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21983/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21983/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21984

• This PR adds an extra 204KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/HGCalAssociatorProducers/interface/AssociatorTools.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366
  • File SimDataFormats/Associations/plugins/BuildFile.xml modified in PR(s): [HGCAL] Tracksters to SimClusters associator #33333
  • File SimDataFormats/Associations/src/classes.h modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333
  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333

[cmsbuild]

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

DataFormats/ParticleFlowReco
SimCalorimetry/HGCalAssociatorProducers
SimDataFormats/Associations

@perrotta, @civanch, @kpedro88, @cmsbuild, @srimanob, @mdhildreth, @slava77, @jpata can you please review it and eventually sign? Thanks.
@hatakeyamak, @rovere, @lgray, @apsallid, @cbernet, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/22112

• This PR adds an extra 220KB to repository

• Found files with invalid states:

  • SimDataFormats/Associations/plugins/MCToCPAssociatorEDProducer.cc:
    • Added: 9266ce2
    • Modified: f31f25c, 4bc0d03
    • Deleted: 897fd82

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimCalorimetry/HGCalAssociatorProducers/interface/AssociatorTools.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366
  • File SimDataFormats/Associations/src/classes.h modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186
  • File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186

[cmsbuild]

Pull request #33384 was updated. @perrotta, @civanch, @kpedro88, @cmsbuild, @srimanob, @mdhildreth, @slava77, @jpata can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61da68/14247/summary.html
COMMIT: 9572be0
CMSSW: CMSSW_11_3_X_2021-04-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33384/14247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2864426
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2864403
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33384 9572be0

• the reconstruction category part is almost trivial addition of a typedef in DataFormats/ParticleFlowReco/interface/HGCalMultiCluster.h

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1