MTD geometry, digitization, reconstruction and validation: technical cleaning of code

[fabiocos]

PR description:

This PR addresses a number of technical issues related to MTD code, without implying any effect on its output. In detail:

• Move EventSetup use to ESGetToken (with the exception of digitization, already addressed by @makortel in Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697)
• Remove the RecHitTools class, now obsolete and unused
• Remove the RecoMTD/Navigation package, unused and not needed after the developments in Addition of the MTD to the tracker Navigation #33272 (no point in maintaining useless code)
• clang-tidy cleaning of code

PR validation:

code compiles and run, geometry unit tests look ok, and test wf 34634.0 do not show differences in its DQM output

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33374/21963

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/MTDGeometryBuilder/test/MTDDigiGeometryAnalyzer.cc modified in PR(s): Rectangular mtd cleaning #33340
  • File Geometry/MTDNumberingBuilder/test/DD4hep_MTDTopologyAnalyzer.cc modified in PR(s): Rectangular mtd cleaning #33340
  • File Geometry/MTDNumberingBuilder/test/MTDTopologyAnalyzer.cc modified in PR(s): Rectangular mtd cleaning #33340

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder
RecoLocalFastTime/FTLClusterizer
RecoLocalFastTime/FTLCommonAlgos
RecoLocalFastTime/FTLRecProducers
RecoMTD/DetLayers
RecoMTD/Navigation
RecoMTD/TrackExtender
SimFastTiming/FastTimingCommon

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88, @slava77, @jpata can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-925ef4/14101/summary.html
COMMIT: 6eff6a9
CMSSW: CMSSW_11_3_X_2021-04-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33374/14101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2865483
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-925ef4/14141/summary.html
COMMIT: 7a81e69
CMSSW: CMSSW_11_3_X_2021-04-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33374/14141/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865506
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2865471
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[jfernan2]

+1

[perrotta]

+1

• Code cleaning implemented as planned
• Jenkins tests pass with no differences in outputs

[civanch]

+1

[srimanob]

+Upgrade

Technical cleaning, no change is expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1