-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DQM/TrackerRemapper package #33280
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33280/21786
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/OfflineValidation The following packages do not have a category, yet: DQM/TrackerRemapper @malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
assign dqm |
New categories assigned: dqm @jfernan2,@andrius-k,@ahmad3213,@kmaeshima,@rvenditti,@ErnestaP you have been requested to review this Pull request/Issue and eventually sign? Thanks |
-1 Failed Tests: HeaderConsistency Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33280/21803
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33280/21907
|
Pull request #33280 was updated. @malbouis, @andrius-k, @yuanchao, @kmaeshima, @christopheralanwest, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @tlampen, @ggovi, @pohsun, @rvenditti, @francescobrivio can you please check and sign again. |
Sorry for the iterations. The last round of commits addresses violation of cmssw coding rule 4.3:
now it should be in the final version. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1586a/14015/summary.html Comparison SummarySummary:
|
+1 |
+1 |
@malbouis, @yuanchao, @christopheralanwest, @tlampen, @francescobrivio
Thank you |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is to introduce a new package
DQM/TrackerRemapper
which is targeted to contain software meant to produce various visualizations of the Pixel and Strip Tracker, scattered previously in other places (mainly inCondCore/SiPixelPlugins
), mainly to avoid awkward dependencies fromCondCore
.The new package contains the following interfaces:
Phase1PixelMaps
: meant for separate Phase-1 Pixel Barrel and Forward Maps;Phase1PixelROCMaps
: meant for Phase-1 Pixel maps at the ROC-level;Phase1PixelSummaryMap:
meant for Summary Phase-1 Pixel maps;SiStripTkMaps.h
: meant for Strip Tracker MapsThese classes are depend on
TH2Poly
objects built using the raw data available at https://github.com/cms-data/DQM-SiStripMonitorClient/tree/master/Geometry.The new classes are then used in various places (mainly in the Pixel and Strip Payload Inspector packages), but also in some analyzers in
Alignment/OfflineValidation
.In addition it contains two analyzers that are meant for re-mapping studies of existing DQM histograms:
SiPixelPhase1Analyzer
TrackerRemapper
These are useful to produce more easily readable histograms from the DQM histograms available on the GUI.
We foresee this package to evolve to include also visualization aids for the Phase-2 Trackers.
PR validation:
This branch passes unit tests, as well as private tests.
An example plot obtainable with the following command is:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport is needed.