-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt python code to updated ML software #32942
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32942/21172
|
A new Pull Request was created by @riga (Marcel R.) for master. It involves the following packages: PhysicsTools/PythonAnalysis @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1c825/12965/summary.html Comparison SummarySummary:
|
+reconstruction
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description
This PR adds some minimal changes to ML related python code in
PhysicsTools/PythonAnalyses
andPhysicsTools/TensorFlow
that came up in the integration process of updated python packages in cms-sw/cmsdist#6649 which was merged yesterday.Changes:
PhysicsTools/PythonAnalyses
used an import that was working for Python2 but not for Python3. This is now fixed for both versions.cmsml
package was introduced in the linked PR and deprecates a few tools previously located inPhysicsTools/TensorFlow/python/tools.py
. As far as I see, these tools were only used in thePhysicsTools/TensorFlow
tests, which I updated accordingly.PR validation
The unit tests of both packages are passing now.