Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt python code to updated ML software #32942

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

riga
Copy link
Contributor

@riga riga commented Feb 18, 2021

PR description

This PR adds some minimal changes to ML related python code in PhysicsTools/PythonAnalyses and PhysicsTools/TensorFlow that came up in the integration process of updated python packages in cms-sw/cmsdist#6649 which was merged yesterday.

Changes:

  • One unit test in PhysicsTools/PythonAnalyses used an import that was working for Python2 but not for Python3. This is now fixed for both versions.
  • The cmsml package was introduced in the linked PR and deprecates a few tools previously located in PhysicsTools/TensorFlow/python/tools.py. As far as I see, these tools were only used in the PhysicsTools/TensorFlow tests, which I updated accordingly.

PR validation

The unit tests of both packages are passing now.

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Feb 18, 2021
@riga riga changed the title Ml software adaption Adapt python code to updated ML software Feb 18, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32942/21172

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @riga (Marcel R.) for master.

It involves the following packages:

PhysicsTools/PythonAnalysis
PhysicsTools/TensorFlow

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1c825/12965/summary.html
COMMIT: 0a6d083
CMSSW: CMSSW_11_3_X_2021-02-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32942/12965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2750949
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jpata
Copy link
Contributor

jpata commented Feb 23, 2021

+reconstruction

  • removes some testing code which now lives in an external package
  • nothing relevant is changed for the reco tests as expected

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f17886c into cms-sw:master Feb 23, 2021
@santocch
Copy link

santocch commented Mar 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants