-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HLTriggerOffline/Egamma/test/testPatRecoElectrons.py #32914
Remove HLTriggerOffline/Egamma/test/testPatRecoElectrons.py #32914
Conversation
please test |
@cms-sw/hlt-l2 @cms-sw/dqm-l2 please add in cc the EGM experts. |
cc @jainshilpi |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32914/21142
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: HLTriggerOffline/Egamma @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
looks to me that it can be removed |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
The error is not related to this PR
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
merge |
In view of the cleaning of obsolete Analysis modules - in particular
ElectroWeakAnalysis/WENu
- I'm trying to remove the dependencies from these packages.HLTriggerOffline/Egamma/test/testPatRecoElectrons.py
containsprocess.load("ElectroWeakAnalysis.WENu.simpleEleIdSequence_cff")
.We might try to copy
simpleEleIdSequence_cff
somewhere, but I see thattestPatRecoElectrons.py
is currently broken, so I think we can simply remove this test file.This PR is related to the cleaning of the Analysis packages (#32917)