Add setStatOverflows to get the mean value including the overflow

[hatakeyamak]

PR description:

It looks like somehow the behavior of getting the mean from the histogram changed. For offset plots, we wanted to get the mean of mu (true number of PU) and npv (number of primary vertex) including the overflow bin, but this wasn't the case any longer, and the code was picking up means from the visible range. This resulted in picking up offset histograms from lower npv than desired.

You can see the change from 11_2_0_pre9 to 11_3_0_pre1:
https://tinyurl.com/y4pudarn

PR validation:

Run the validation sequence with this change, and made sure now we can pick up mean including the overview.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not backport.

@bendavid @juska

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32720/20856

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test with #32364

[hatakeyamak]

Thank you. @jfernan2 do you have some idea why we now need to add setStatOverflows explicitly? Is this due to some upstream validation software update?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-930ae9/12486/summary.html
COMMIT: 4c79fbd
CMSSW: CMSSW_11_3_X_2021-01-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32720/12486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716920
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jfernan2]

@hatakeyamak I believe it is due to ROOT which now implements a per-object flag, see:
#32343 (comment)

[jfernan2]

please test with #32364
Launching the test again since before it did not cath the extra PR

[hatakeyamak]

@hatakeyamak I believe it is due to ROOT which now implements a per-object flag, see:
#32343 (comment)

I see. Thank you for clarification.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-930ae9/12494/summary.html
COMMIT: 4c79fbd
CMSSW: CMSSW_11_3_X_2021-01-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32720/12494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1