drop type specifications in RecoTracker

[jeongeun]

PR description:

Update the safer syntax for existing parameter :

• drop type specifications where the original parameter exists.
• move all parameter inside the clone/modifier

Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.
(All submitted PRs for RecoTracker are PR#30556 and PR#30671, PR#30700, PR#30827, and PR#30947 . )

In this PR, a total of 11 files changed.

RecoTracker/Configuration 1 file
RecoTracker/ConversionSeedGenerators 2 files
RecoTracker/DeDx 1 file
RecoTracker/FinalTrackSelectors 1 file
RecoTracker/IterativeTracking 5 files
RecoTracker/MeasurementDet 1 file

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32694/20804

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/IterativeTracking/python/InitialStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128
  • File RecoTracker/IterativeTracking/python/LowPtQuadStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128
  • File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128
  • File RecoTracker/IterativeTracking/python/PixelPairStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoTracker/Configuration
RecoTracker/ConversionSeedGenerators
RecoTracker/DeDx
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking
RecoTracker/MeasurementDet

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f76e30/12382/summary.html
COMMIT: 91d872b
CMSSW: CMSSW_11_3_X_2021-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32694/12382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716961
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716932
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[perrotta]

Since you are there, you can complete the job by updating also these two lines, even if commented out
Beside that, the PR is ready to go

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32694/20872

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/IterativeTracking/python/InitialStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128
  • File RecoTracker/IterativeTracking/python/LowPtQuadStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128
  • File RecoTracker/IterativeTracking/python/PixelLessStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128
  • File RecoTracker/IterativeTracking/python/PixelPairStep_cff.py modified in PR(s): Track classifier using TensorFlow - continuation #32128

[cmsbuild]

Pull request #32694 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f76e30/12506/summary.html
COMMIT: 7e02386
CMSSW: CMSSW_11_3_X_2021-01-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32694/12506/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

[perrotta]

+1

• Types dropped from cloned/modified configs as planned
• Jenkisn tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1