Use cleaned PF candidates in UE subtraction in HI miniAOD

[mandrenguyen]

PR description:

In #31668 a cleaning procedure was added to HI miniAOD to remove badly reconstructed particles. This procedure was applied prior to jet clustering (akCs4PFJets), but not applied to the towering algorithm (PFTowers) that is used for the UE subtraction. This leads to an inconsistency with our previous AOD-only workflow. The cleaning is only effective occasionally such that the net effect is a small migration of in the jet pt spectrum.
11_2 backport is #32330.

PR validation:

Wfs 140.5611 and 158.01

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32325/20156

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

RecoHI/HiJetAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @yenjie, @kurtejung, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test with workflow 140.5611

[perrotta]

please test workflow 140.5611

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 140.5611
• CMSSW_11_3_X_2020-11-29-0000/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11147/console Started: 2020/11/29 22:39

[cmsbuild]

+1
Tested at: a838c2c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67ed07/11147/summary.html
CMSSW: CMSSW_11_3_X_2020-11-29-0000
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67ed07/11147/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• Reco comparison had 1 failed jobs
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2529564
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cms-bot#1433
Test Parameters:

• MATRIX_EXTRAS = 140.5611
• CMSSW_11_3_X_2020-11-30-1100/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11191/console Started: 2020/12/01 04:17

[cmsbuild]

+1
Tested at: a838c2c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d690f3/11191/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d690f3/11191/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529593
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2529557
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 148 log files, 34 edm output root files, 35 DQM output files

[slava77]

+1

for #32325 a838c2c

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no relevant differences (apparently -- as mentioned in the PR description -- the change is not particularly frequent/visible on low stats as in wf 158.01)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1