CSC RecHit Builder updates

[nvoytish]

PR description:

This PR adds some features to the CSC RecHit Builder.

The addressed problems are:

• simple two overlapped signals delimitation in terms of the strip coordinate;
• improvement of the hit reconstruction in the extreme wire groups of chamber(best improvement for ME11);
• ME11 transition region hit reconstruction improvement.

For details see:
https://indico.cern.ch/event/968978/contributions/4078288/attachments/2133771/3594383/20_10_30-Voytishin_Palichik-CSC_rh_builder_improvement_updates.pdf

[cmsbuild]

The code-checks are being triggered in jenkins.

[nvoytish]

adding @ptcox as co-author

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

RecoLocalMuon/CSCRecHitD/src/CSCMake2DRecHit.cc:159:74: error: use of undeclared identifier 'wilo'; did you mean 'wglo'? [clang-diagnostic-error]
    lp0 = (layergeom_->possibleRecHitPosition( float(centerStrip) - 0.5, wilo, wihi )).first;
                                                                         ^~~~
                                                                         wglo
--
RecoLocalMuon/CSCRecHitD/src/CSCMake2DRecHit.cc:159:80: error: use of undeclared identifier 'wihi'; did you mean 'wghi'? [clang-diagnostic-error]
    lp0 = (layergeom_->possibleRecHitPosition( float(centerStrip) - 0.5, wilo, wihi )).first;
                                                                               ^~~~
                                                                               wghi
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32052/19639

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32052/19639/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32052/19639/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #32052 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@nvoytish
please post a message when you are done with updates in this PR.

[nvoytish]

@nvoytish
please post a message when you are done with updates in this PR.

Hi, @slava77 ! If I didn't miss any issues, it looks like I am done with updates.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• ENABLE_BOT_TESTS = PROFILING
• CMSSW_11_2_X_2020-11-20-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10914/console Started: 2020/11/20 21:22

[cmsbuild]

+1
Tested at: b0c4ff2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f461d2/10914/summary.html
CMSSW: CMSSW_11_2_X_2020-11-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f461d2/10914/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7145 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2962300
• DQMHistoTests: Total failures: 37565
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2924713
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[slava77]

+1

for #32199 cf54157

• updates are in line with the details presented in the reco meeting (see the link in the PR description)
• jenkins tests pass and comparisons with the baseline show differences starting from somewhat small changes in the cscSegments and propagating to downstream quantities. As expected, there are more segments and the segments are longer.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[makortel]

This PR might be causing heap-buffer-overflow failures in ASAN build in CSCXonStrip_MatchGatti::estimated2GattiCorrection(), please see #32274.