[RecoEgamma/EgammaTools] Backport of UL 2018 scale and smearing corrections

[jainshilpi]

This is a backport of PR #31936 of UL2018 scale and smearing corrections.
UL 2017 corrections were already in the backport but now we use run specific modifier
to activate these.

[cmsbuild]

A new Pull Request was created by @jainshilpi for CMSSW_10_6_X.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@sobhatta, @afiqaize, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

test parameters:

• pull_request = update EgammaAnalysis-ElectronTools to V00-03-00 cmsdist#6362

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6362

• CMSSW_10_6_X_2020-11-03-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10475/console Started: 2020/11/03 16:17

[slava77]

abort test

[cmsbuild]

Jenkins tests are aborted.

[slava77]

Suggested change

	run2_egamma_2017.toModify(calibratedEgammaSettings,correctionFile = _correctionFile2017UL)
	from Configuration.Eras.Modifier_run2_egamma_2018_cff import run2_egamma_2018
	run2_egamma_2018.toModify(calibratedEgammaSettings,correctionFile = _correctionFile2018UL)
	from Configuration.ProcessModifiers.run2_miniAOD_UL_cff import run2_miniAOD_UL
	(run2_miniAOD_UL & run2_egamma_2017).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2017UL)
	from Configuration.Eras.Modifier_run2_egamma_2018_cff import run2_egamma_2018
	(run2_miniAOD_UL & run2_egamma_2018).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2018UL)

the updates are expected to be only for UL setup in the backport.
IIUC, in this case, without my proposed change, this PR will override the behavior for run2_miniAOD_94XFall17

[cmsbuild]

Pull request #31995 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6362

• CMSSW_10_6_X_2020-11-03-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10479/console Started: 2020/11/03 18:10

[cmsbuild]

+1
Tested at: 6d5cfb4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87c42/10479/summary.html
CMSSW: CMSSW_10_6_X_2020-11-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87c42/10479/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214664
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214328
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[slava77]

+1

for #31995 6d5cfb4

• the backport is consistent with UL2018 scale and smearing added #31936 ; changes in the code are not identical and are enabled explicitly only for run2_miniAOD_UL to satisfy the no-change rules
• jenkins tests pass and comparisons with the baseline show differences only in the UL re-miniAOD workflow 136.88811 as expected; the differences look the same as in the master version comparisons

cms-sw/cmsdist#6362 is required to be present/merged before merging this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1