Fix bug in NanoGEN precision setting #31973

kdlong · 2020-10-28T14:25:00Z

PR description:

Fix bug in precision setting of gen variables in NanoGEN

PR validation:

It works as intended now

cmsbuild · 2020-10-28T14:25:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-28T14:31:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31973/19433

This PR adds an extra 16KB to repository

cmsbuild · 2020-10-28T14:31:26Z

A new Pull Request was created by @kdlong (Kenneth Long) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2020-10-28T14:40:59Z

please test workflow 546,547,548

cmsbuild · 2020-10-28T14:41:18Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 548,546,547
CMSSW_11_2_X_2020-10-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10351/console Started: 2020/10/28 15:42

cmsbuild · 2020-10-28T16:03:07Z

-1

Tested at: a9b6604

CMSSW: CMSSW_11_2_X_2020-10-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-793d42/10351/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
546.0 step2

runTheMatrix-results/546.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen/step2_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen.log

548.0 step3

runTheMatrix-results/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen/step3_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen.log

547.0 step3

runTheMatrix-results/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen/step3_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen.log

cmsbuild · 2020-10-28T16:03:09Z

Comparison job queued.

mariadalfonso · 2020-10-28T16:43:31Z

@kdlong
the bug fix proposed here is not correct we are asking Eta of MET

Step: DQM Spec: ['@nanogenDQM']
customising the process with customizeNanoGENFromMini from PhysicsTools/NanoAOD/nanogen_cff
Traceback (most recent call last):
File "/cvmfs/cms-ib.cern.ch/nweek-02652/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-10-27-1100/bin/slc7_amd64_gcc820/cmsDriver.py", line 56, in
run()
File "/cvmfs/cms-ib.cern.ch/nweek-02652/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-10-27-1100/bin/slc7_amd64_gcc820/cmsDriver.py", line 28, in run
configBuilder.prepare()
File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-27-2300/python/Configuration/Applications/ConfigBuilder.py", line 2273, in prepare
self.pythonCfgCode += self.addCustomise()
File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-27-2300/python/Configuration/Applications/ConfigBuilder.py", line 885, in addCustomise
self.process=getattr(package,fcn)(self.process)
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-27-2300/python/PhysicsTools/NanoAOD/nanogen_cff.py", line 77, in customizeNanoGENFromMini
nanoGenCommonCustomize(process)
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-27-2300/python/PhysicsTools/NanoAOD/nanogen_cff.py", line 56, in nanoGenCommonCustomize
setGenEtaPrecision(process, CandVars.eta.precision)
File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-27-2300/python/PhysicsTools/NanoAOD/nanogen_cff.py", line 137, in setGenEtaPrecision
process.metMCTable.variables.eta.precision = precision
AttributeError: 'PSet' object has no attribute 'eta'

Better code reuse

cmsbuild · 2020-10-29T12:19:38Z

Pull request #31973 was updated. @cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

mariadalfonso · 2020-10-29T14:09:25Z

please test workflow 546,547,548

cmsbuild · 2020-10-29T14:09:50Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 548,546,547
CMSSW_11_2_X_2020-10-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10388/console Started: 2020/10/29 16:23

cmsbuild · 2020-10-29T16:45:51Z

+1
Tested at: da11c5e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-793d42/10388/summary.html
CMSSW: CMSSW_11_2_X_2020-10-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-29T16:45:52Z

Comparison job queued.

cmsbuild · 2020-10-29T18:00:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-793d42/10388/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-793d42/546.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-793d42/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-793d42/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544092
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544069
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

mariadalfonso · 2020-10-29T18:51:41Z

+xpog

updates only to GENnano inline with description

silviodonato · 2020-11-02T09:17:05Z

merge
@santocch please have a look

santocch · 2020-11-03T17:46:16Z

+2

santocch · 2020-11-03T17:46:26Z

+1

cmsbuild · 2020-11-03T17:46:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Backport of #30306, #31591, and #31973: NanoGen support in 10_6_X

cmsbuild added this to the CMSSW_11_2_X milestone Oct 28, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending xpog-pending labels Oct 28, 2020

kdlong mentioned this pull request Oct 28, 2020

Backport of #30306, #31591, and #31973: NanoGen support in 10_6_X #31909

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 28, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 28, 2020

mariadalfonso mentioned this pull request Oct 28, 2020

features for V8 nanoAOD cms-nanoAOD/cmssw#533

Closed

55 tasks

cmsbuild added tests-rejected and removed tests-started labels Oct 28, 2020

Fix bug in NanoGEN precision setting

da11c5e

Better code reuse

kdlong force-pushed the NanoGen_dqm branch from a9b6604 to da11c5e Compare October 29, 2020 12:12

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Oct 29, 2020

cmsbuild added the code-checks-approved label Oct 29, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 29, 2020

cmsbuild added xpog-approved and removed xpog-pending labels Oct 29, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 2, 2020

cmsbuild merged commit 97b4817 into cms-sw:master Nov 2, 2020

cmsbuild mentioned this pull request Nov 2, 2020

Restore "PPS Digi integration into cmssw (final)" #32003

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Nov 3, 2020

cmsbuild mentioned this pull request Nov 4, 2020

Switch to Geant4 thermal neutron physics #32009

Merged

cmsbuild added a commit that referenced this pull request Nov 4, 2020

Merge pull request #31909 from kdlong/NanoGen_10_6_18_backport

ff93e45

Backport of #30306, #31591, and #31973: NanoGen support in 10_6_X

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug in NanoGEN precision setting #31973

Fix bug in NanoGEN precision setting #31973

kdlong commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

mariadalfonso commented Oct 28, 2020

cmsbuild commented Oct 28, 2020 •

edited

Loading

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

mariadalfonso commented Oct 28, 2020 •

edited

Loading

cmsbuild commented Oct 29, 2020

mariadalfonso commented Oct 29, 2020

cmsbuild commented Oct 29, 2020 •

edited

Loading

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

mariadalfonso commented Oct 29, 2020

silviodonato commented Nov 2, 2020

santocch commented Nov 3, 2020

santocch commented Nov 3, 2020

cmsbuild commented Nov 3, 2020

Fix bug in NanoGEN precision setting #31973

Fix bug in NanoGEN precision setting #31973

Conversation

kdlong commented Oct 28, 2020

PR description:

PR validation:

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

mariadalfonso commented Oct 28, 2020

cmsbuild commented Oct 28, 2020 • edited Loading

cmsbuild commented Oct 28, 2020

cmsbuild commented Oct 28, 2020

mariadalfonso commented Oct 28, 2020 • edited Loading

cmsbuild commented Oct 29, 2020

mariadalfonso commented Oct 29, 2020

cmsbuild commented Oct 29, 2020 • edited Loading

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

cmsbuild commented Oct 29, 2020

mariadalfonso commented Oct 29, 2020

silviodonato commented Nov 2, 2020

santocch commented Nov 3, 2020

santocch commented Nov 3, 2020

cmsbuild commented Nov 3, 2020

cmsbuild commented Oct 28, 2020 •

edited

Loading

mariadalfonso commented Oct 28, 2020 •

edited

Loading

cmsbuild commented Oct 29, 2020 •

edited

Loading