PPS Digi integration into cmssw (final) #31943
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31943/19388
|
|
A new Pull Request was created by @mundim for master. It involves the following packages: Configuration/StandardSequences @silviodonato, @cmsbuild, @franzoni, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -19,8 +19,7 @@ | |||
| from L1Trigger.Configuration.L1TDigiToRaw_cff import * | |||
| from EventFilter.CTPPSRawToDigi.ctppsDigiToRaw_cff import * | |||
|
|
|||
| #DigiToRawTask = cms.Task(L1TDigiToRawTask, siPixelRawData, SiStripDigiToRaw, ecalPacker, esDigiToRaw, hcalRawDataTask, cscpacker, dtpacker, rpcpacker, ctppsRawData, castorRawData, rawDataCollector) | |||
| DigiToRawTask = cms.Task(L1TDigiToRawTask, siPixelRawData, SiStripDigiToRaw, ecalPacker, esDigiToRaw, hcalRawDataTask, cscpacker, dtpacker, rpcpacker, castorRawData, rawDataCollector) | |||
| DigiToRawTask = cms.Task(L1TDigiToRawTask, siPixelRawData, SiStripDigiToRaw, ecalPacker, esDigiToRaw, hcalRawDataTask, cscpacker, dtpacker, rpcpacker, ctppsRawData, castorRawData, rawDataCollector) | |||
There was a problem hiding this comment.
Does something actually consume the product(s) of ctppsRawData producer? (by quick git grep ctppsRawData I was not able to see any)
If nothing consumes ctppsRawData, it, and all modules whose products consumed only by it, are not run.
There was a problem hiding this comment.
Yes, but to do so, a flag, defined in g4SimHits_cff.py (LHCTransport = cms.bool(True)) needs to be set to true. This was implemented by @civanch to deal with the way PPS was downgrading the CMS simulation. In summary, it will be consumed for PPS simulation with the flago above set to true. Just to be 100% sure, I just tested it again, without the ctppsRawData there is no reco hits or tracks at the end.
Thanks.
There was a problem hiding this comment.
If I understand correctly, this is enable with ctpps_2021 here
https://github.com/cms-sw/cmssw/blob/master/EventFilter/CTPPSRawToDigi/python/ctppsDigiToRaw_cff.py#L20
and consumed here
https://github.com/cms-sw/cmssw/blob/master/EventFilter/RawDataCollector/python/rawDataCollector_cfi.py#L40
There was a problem hiding this comment.
Ah, right, ctppsRawData is a Task, and the relevant modules are consumed by the rawDataCollector. Thanks for the clarification, and sorry for the noise.
There was a problem hiding this comment.
No problem at all. Thank you.
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
PPS digi integration into cmssw. This is the last step towards the integration of PPS simulation into CMSSW and was delayed waiting for the new cms extended geometry (including PPS) to show up in the DB.
PR validation:
scram b runtests
scram b code-checks
scram b code-format
with no issue.
As for runTheMatrix, it was run with the command below (hopefully only Run3 wf)
runTheMatrix.py --job-reports --ibeos -l 4.22,4.53,5.1,7.3,8.0,9.0,25.0,135.4,136.731,136.7611,136.793,136.8311,136.874,136.88811,140.53,140.56,158.0,158.01,1306.0,1325.7,1330.0,101.0,25202.0,1000.0,1001.0,10024.0,10042.0,10224.0,10824.0,11634.0,12434.0,23234.0,23434.999,28234.0,250202.181
which produced:
35 34 33 25 17 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: