[DD4hep] ProdCuts Selection Allows regex Comparison #31919

ianna · 2020-10-23T09:38:28Z

PR description:

use regex comparison

@bsunanda - FYI

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-10-23T09:38:55Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-23T09:48:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31919/19343

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Close Geometry and Use Regex for Production Cuts Selection #31915, Update of the Scenario 2021 after that the Muon Subtraction Solids have been fixed #31918
- File SimG4Core/Geometry/src/DDG4ProductionCuts.cc modified in PR(s): [DD4hep] Close Geometry and Use Regex for Production Cuts Selection #31915

cmsbuild · 2020-10-23T09:48:51Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData
SimG4Core/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @rovere, @argiro, @rchatter, @thomreis, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

ianna · 2020-10-23T10:06:44Z

please test

cmsbuild · 2020-10-23T10:07:06Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-22-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10237/console Started: 2020/10/23 12:38

cmsbuild · 2020-10-23T11:49:14Z

-1

Tested at: c220d42

CMSSW: CMSSW_11_2_X_2020-10-22-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd087b/10237/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+/bin/sh:/step2_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

23434.999 step2

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

28234.0 step2

runTheMatrix-results/28234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

cmsbuild · 2020-10-23T11:49:16Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

ianna · 2020-10-23T12:29:59Z

please test

cmsbuild · 2020-10-23T15:20:13Z

Pull request #31919 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

ianna · 2020-10-23T15:23:05Z

please test

ianna · 2020-10-23T15:24:39Z

Ideally dd4hep will have names with namespace - but during creation of G4 geometry the namespace should be stripped off. Then all our problems will be solved.

Unfortunately, it's out of our control - we create TGeo and pass it to DD4hep G4 converter asis.

ianna · 2020-10-23T16:25:14Z

please test

cmsbuild · 2020-10-23T16:25:39Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10256/console Started: 2020/10/23 18:28

cmsbuild · 2020-10-23T17:36:48Z

+1
Tested at: ba6f3b3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd087b/10256/summary.html
CMSSW: CMSSW_11_2_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-23T17:36:50Z

Comparison job queued.

ianna · 2020-10-23T17:54:24Z

+1

cmsbuild · 2020-10-23T18:50:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd087b/10256/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544110
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544087
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

civanch · 2020-10-23T19:52:10Z

+1

I am a bit confused, these modifications were in another PR are should be already merged.

kpedro88 · 2020-10-23T20:15:46Z

@ianna this seems redundant with #31915, is it still needed?

ghugo83 · 2020-10-26T09:07:44Z

const std::string& cryName(baseNumber.getLevelName(0).substr(0, 7)); // name of crystal volume

const std::string& cryName(baseNumber.getLevelName(0).substr(7, 14)); // name of crystal volume
@bsunanda https://github.com/bsunanda - I'm reverting this change since it breaks the DD-based workflows. Could you or >@ghugo83 https://github.com/ghugo83, please, provide a proper solution? Thanks.

@ianna Ok will push a fix soon.

ianna added 3 commits October 23, 2020 08:27

close geometry

c54b5e0

code format

9df3e36

account for namespace

c220d42

ianna changed the title ~~[DD4hep} Ecal barrel numbering with namespace~~ [DD4hep] Ecal barrel numbering with namespace Oct 23, 2020

cmsbuild added this to the CMSSW_11_2_X milestone Oct 23, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Oct 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 23, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 23, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 23, 2020

cmsbuild removed the comparison-notrun label Oct 23, 2020

cmsbuild added the code-checks-approved label Oct 23, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 23, 2020

cmsbuild added tests-pending and removed tests-started labels Oct 23, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 23, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 23, 2020

cmsbuild added geometry-approved and removed geometry-pending labels Oct 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 23, 2020

cmsbuild added simulation-approved and removed simulation-pending labels Oct 23, 2020

bsunanda mentioned this pull request Oct 24, 2020

Run3-gex28 Take care of namespace issue for EB numbering in dd4hep #31931

Merged

cmsbuild mentioned this pull request Oct 24, 2020

Phase2-gex28 Add a new cff for simulation - useful for dd4hep #31929

Merged

ianna closed this Oct 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DD4hep] ProdCuts Selection Allows regex Comparison #31919

[DD4hep] ProdCuts Selection Allows regex Comparison #31919

ianna commented Oct 23, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

ianna commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

civanch commented Oct 23, 2020

kpedro88 commented Oct 23, 2020

ghugo83 commented Oct 26, 2020

[DD4hep] ProdCuts Selection Allows regex Comparison #31919

[DD4hep] ProdCuts Selection Allows regex Comparison #31919

Conversation

ianna commented Oct 23, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 • edited Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

ianna commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 • edited Loading

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

ianna commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

civanch commented Oct 23, 2020

kpedro88 commented Oct 23, 2020

ghugo83 commented Oct 26, 2020

ianna commented Oct 23, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020 •

edited

Loading

cmsbuild commented Oct 23, 2020 •

edited

Loading