Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CaloTowers for hcal flexible segmentation in Phase 2 #3187

Merged
merged 9 commits into from
Apr 4, 2014

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Apr 3, 2014

Upgrade CaloTowers:
flexible ieta, iphi, depth values
ieta values are continuous; may not match HCAL ieta (Phase 2 HCAL ieta is not always continuous between subdetectors)
topology and geometry stored in ES records, dependent on HcalTopology
EE cells mapped to HE towers using getClosestCell() from geometry for Phase 2 HCAL (preliminary method)

This is a rather large pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

Update CaloTowers for hcal flexible segmentation in Phase 2

It involves the following packages:

CondTools/Geometry
DataFormats/CaloTowers
FastSimulation/L1CaloTriggerProducer
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/EcalTestBeam
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo
HLTrigger/HLTanalyzers
HLTrigger/JetMET
RecoEgamma/EgammaIsolationAlgos
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecProducers
RecoParticleFlow/PFClusterProducer
RecoTauTag/RecoTau
SLHCUpgradeSimulations/Configuration
SimDataFormats/EcalTestBeam

@perrotta, @cmsbuild, @apfeiffer1, @Dr15Jones, @lveldere, @civanch, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @anton-a, @thspeer, @giamman, @slava77, @ggovi, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @lgray, @jpavel, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor

@kpedro88 - I'm getting this error

Traceback (most recent call last):
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-31-0200/bin/slc5_amd64_gcc472/cmsDriver.py", line 43, in <module>
    run()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-31-0200/bin/slc5_amd64_gcc472/cmsDriver.py", line 15, in run
    configBuilder.prepare()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw-patch/CMSSW_6_2_X_SLHC_2014-04-03-0200/python/Configuration/Applications/ConfigBuilder.py", line 2105
, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw-patch/CMSSW_6_2_X_SLHC_2014-04-03-0200/python/Configuration/Applications/ConfigBuilder.py", line 795,
 in addCustomise
    self.process=getattr(package,fcn)(self.process)
  File "/afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-04-03-0200/python/SLHCUpgradeSimulations/Configuration/combinedCustoms.py", line 48, in cust_phase2_BE5D
    process=customise_HcalPhase2(process)
  File "/afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-04-03-0200/python/SLHCUpgradeSimulations/Configuration/HCalCustoms.py", line 101, in customise_HcalPhase2
    process.CaloTowerConstituentsMapBuilder.MapFile = cms.untracked.string("")
AttributeError: 'Process' object has no attribute 'CaloTowerConstituentsMapBuilder'

for several tests. Is there something new about the CaloTowerConstituentsMapBuilder? Has it been removed or renamed?

runTheMatrix.py -w upgrade -l 13000

@kpedro88
Copy link
Contributor Author

kpedro88 commented Apr 3, 2014

It hasn't been removed or renamed. I added that line because the map file is not correct for Phase 2. It could be wrong; I got it from the edmConfigBrowser. Maybe the CaloTowerConstituentsMapBuilder is actually subordinate to some other process?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

Pull request #3187 was updated. @perrotta, @cmsbuild, @apfeiffer1, @Dr15Jones, @lveldere, @civanch, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @anton-a, @thspeer, @giamman, @slava77, @ggovi, @Degano, @ktf, @nclopezo can you please check and sign again.

process.towerMakerPF.HcalPhase = cms.int32(2)
process.towerMakerWithHO.HcalPhase = cms.int32(2)

process.CaloTowerConstituentsMapBuilder.MapFile = cms.untracked.string("")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module doesn't exist until RECO. You should wrap this line in an appropriate test.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

Pull request #3187 was updated. @perrotta, @cmsbuild, @apfeiffer1, @Dr15Jones, @lveldere, @civanch, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @anton-a, @thspeer, @giamman, @slava77, @ggovi, @Degano, @ktf, @nclopezo can you please check and sign again.

@lveldere
Copy link
Contributor

lveldere commented Apr 4, 2014

+1

@kpedro88
Copy link
Contributor Author

kpedro88 commented Apr 4, 2014

I realized just now that my previous commit (fix process dependence) had pushed a version of HCalCustoms from before I rebased the branch, so I undid it and pushed a correct commit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2014

Pull request #3187 was updated. @perrotta, @cmsbuild, @apfeiffer1, @Dr15Jones, @lveldere, @civanch, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @anton-a, @thspeer, @giamman, @slava77, @ggovi, @Degano, @ktf, @nclopezo can you please check and sign again.

@mark-grimes
Copy link

merge

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000 and 13600 pass all steps.
Tests 12400, 12600, 13200, 13400, 13800 and 14000 fail in step 2 with known errors.

Tests 12200 (Extended2023HGCalMuon), 14200 (Extended2023HGCal) and 14400 (Extended2023HGCalMuon4Eta) still fail in step 2, but now with a different error:

----- Begin Fatal Exception 04-Apr-2014 20:13:05 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'digitisation_step'
   [2] Calling beginRun for module MixingModule/'mix'
   [3] Using EventSetup component CaloGeometryBuilder/'' to make data CaloGeometry/'' in record CaloGeometryRecord
   [4] Using EventSetup component CaloTowerHardcodeGeometryEP/'' to make data CaloSubdetectorGeometry/'TOWER' in record CaloTowerGeometryRecord
Exception Message:
No data of type "CaloTowerTopology" with label "" in record "HcalRecNumberingRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

cmsbuild added a commit that referenced this pull request Apr 4, 2014
Update CaloTowers for hcal flexible segmentation in Phase 2
@cmsbuild cmsbuild merged commit a558508 into cms-sw:CMSSW_6_2_X_SLHC Apr 4, 2014
@kpedro88
Copy link
Contributor Author

kpedro88 commented Apr 4, 2014

I understand the source of this error: the typical geometry configuration imports Geometry.CaloEventSetup.CaloGeometry_cff, which knows about CaloTowerTopology_cfi. In the HGCal geometries, the imports usually in CaloGeometry_cff are instead done one-by-one because of changes to which calorimeters are included. To fix these errors, this line can be added to GeometryExtended2023HGCalReco_cff and any other HGCal reco geometries:
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import *
I do not have time to do it at this moment (leaving Karlsruhe in the morning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants