esConsumes migration for EDModules in SiStrip packages, part 1

[pieterdavid]

PR description:

esConsumes migration #31061 for modules in packages with SiStrip in the name, outside DQM/ (which more or less splits the list in two - the rest will be submitted as a separate PR).
I tried to follow the instructions from #31061, and keep other changes minimal.
I rebased on an IB after #31756 was merged and did not change the modules migrated in #31697 (SimTracker/SiStripDigitizer and SiStripFedZeroSuppression), so in principle there should be no conflicts.

PR validation:

compiles, and runTheMatrix.py -l limited --useInput all passes - I'm not sure that checks all the transitions/updates, hints on validating that are welcome.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31826/19126

• This PR adds an extra 480KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiStripCommon/plugins/ShallowGainCalibration.h modified in PR(s): Fix issue with Strip CalibTree production and improve unit tests #31643

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

AnalysisAlgos/SiStripClusterInfoProducer
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripDCS
CalibTracker/SiStripESProducers
CalibTracker/SiStripLorentzAngle
CalibTracker/SiStripQuality
CondTools/SiStrip
DPGAnalysis/SiStripTools
DQM/SiStripMonitorHardware
DQMOffline/CalibTracker
EventFilter/SiStripChannelChargeFilter
EventFilter/SiStripRawToDigi
RecoLocalTracker/SiStripClusterizer
RecoLocalTracker/SiStripZeroSuppression

@perrotta, @andrius-k, @yuanchao, @kmaeshima, @emeschi, @tlampen, @christopheralanwest, @ErnestaP, @tocheng, @cmsbuild, @jpata, @jfernan2, @fioriNTU, @slava77, @ggovi, @pohsun, @santocch, @smorovic can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @yduhm, @robervalwalsh, @Martin-Grunewald, @fioriNTU, @threus, @ebrondol, @venturia, @hdelanno, @makortel, @JanFSchulte, @rociovilar, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @jandrea, @alesaggio, @idebruyn, @mmusich, @mtosi, @arossi83, @gbenelli, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10023/console Started: 2020/10/16 16:11

[cmsbuild]

+1
Tested at: 9ca125a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4fb1/10023/summary.html
CMSSW: CMSSW_11_2_X_2020-10-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d4fb1/10023/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 73062
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2470668
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

@pieterdavid it seems this PR creates a huge number of changes in MEs located at AlCaReco and SiStrip folder for several workflows,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_2_X_2020-10-15-2300+9d4fb1/39373/dqm-histo-comparison-summary.html
Is this understood?

[jfernan2]

+1

[santocch]

+1

[yuanchao]

+1

• Static tests warnings not from the parts of modifications

[silviodonato]

@ggovi @cms-sw/db-l2 do you have any comments?

[ggovi]

+1

[silviodonato]

@cms-sw/daq-l2 ?

[smorovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1