Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TrackDetectorAssociator to EventSetup consumes #31802

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

makortel
Copy link
Contributor

PR description:

This PR is part of #31061. It migrates TrackDetectorAssociator helper class to EventSetup consumes as part of my attempt to fix failures of #31746 (i.e. some user of it has been migrated to it). On the same go I migrated calling EDModules to ES consumes, and did some related minimal refactoring.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31802/19090

  • This PR adds an extra 72KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Alignment/OfflineValidation
Calibration/HcalCalibAlgos
Calibration/IsolatedParticles
JetMETCorrections/IsolatedParticles
RecoEcal/EgammaClusterProducers
RecoMET/METProducers
SUSYBSMAnalysis/HSCP
TrackingTools/TrackAssociator

@perrotta, @yuanchao, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @jpata, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @felicepantaleo, @jainshilpi, @abbiendi, @argiro, @thomreis, @tlampen, @lgray, @mmusich, @seemasharmafnal, @mmarionncern, @ahinzmann, @JanFSchulte, @jhgoh, @varuns23, @jdolen, @HuguesBrun, @cericeci, @trocino, @Sam-Harper, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @schoef, @mschrode, @ebrondol, @mtosi, @dgulhan, @clelange, @adewit, @rchatter, @Fedespring, @calderona, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 968b21d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32b990/9974/summary.html
CMSSW: CMSSW_11_2_X_2020-10-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32b990/9974/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543729
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

I was getting link errors without (not really sure why though).
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31802/19210

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #31802 was updated. @perrotta, @yuanchao, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @jpata, @pohsun, @santocch can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: d67bd80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32b990/10091/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32b990/10091/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543723
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@slava77
Copy link
Contributor

slava77 commented Oct 20, 2020

+1

for #31802 d67bd80

  • technical; in line with the PR description
  • jenkins tests pass with no relevant differences

@christopheralanwest
Copy link
Contributor

+alca

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 17ce976 into cms-sw:master Oct 22, 2020
@makortel makortel deleted the esConsumesTrackDetectorAssociator branch October 23, 2020 18:06
@santocch
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants