-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TrackDetectorAssociator to EventSetup consumes #31802
Migrate TrackDetectorAssociator to EventSetup consumes #31802
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31802/19090
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Alignment/OfflineValidation @perrotta, @yuanchao, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @jpata, @pohsun, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
I was getting link errors without (not really sure why though).
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31802/19210
|
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+alca |
merge |
+1 |
PR description:
This PR is part of #31061. It migrates
TrackDetectorAssociator
helper class to EventSetup consumes as part of my attempt to fix failures of #31746 (i.e. some user of it has been migrated to it). On the same go I migrated calling EDModules to ES consumes, and did some related minimal refactoring.PR validation:
Code compiles.