Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete EventSetup-consumes migration for bunch of DQM modules #31761

Closed
wants to merge 2 commits into from

Conversation

makortel
Copy link
Contributor

PR description:

This PR is part of #31061. It completes the EventSetup-consumes migration for bunch of DQM modules that were partly migrated earlier, but were causing failures in #31746.

PR validation:

Code compiles, these modules do not trigger the exception of #31746 in a job using them.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31761/18991

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/L1TMonitor
DQM/SiStripMonitorDigi
DQMOffline/L1Trigger

@benkrikler, @kmaeshima, @andrius-k, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Oct 13, 2020

Let me order these differently.

@makortel makortel closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants