-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DeepTauID modules so they can also process RECO input for HLT purposes #31744
Change DeepTauID modules so they can also process RECO input for HLT purposes #31744
Conversation
- input tokens for candidates and taus now use base classes - taus and candidates accessed by dynamic_cast and edm::View - is_online boolean in fillDescriptions - Electron and muon collections empty if is_online - Changed some quantities with functions that calculate quantity differently depending on the input
Removed 2 leftover comments
- Ran "scram build code-checks" and "scram build code-format" - Implemented the new container format. For now the indices of the discriminators are given as inputs in the config file. I will look into using provenance - Switched order of the if statements (for is_online and version checks) in the getPredictions function - turned tau_index to const
…nc to edm::Handle instead of the vector. The way it was before worked in pre3 but switching to pre5 broke that.
- Change TauRefType to edm::RefToBase<reco::BaseTau>
…ching from provenance.
…scriminators into static const
- Added, removed and changed some option for the basicDiscriminators in the deepTauAtHLT.py config file to be more in line with RecoTauTag/Configuration/HPSPFTaus_cff.py
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31744/18954
|
A new Pull Request was created by @swozniewski for master. It involves the following packages: HLTrigger/Configuration @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cms-sw/hlt-l2 do you have any comments? |
kind reminder @cms-sw/hlt-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation: