Add new CaloL1 offline DQM module and configuration #31678

aloeliger · 2020-10-06T09:51:13Z

PR description:

A new CaloL1 DQM offline module in "Global" format has been introduced to comply with the concurrent LS processing introduced for the offline DQM as a part of #25090. This offline module is largely a duplicate of the online version of the L1TStage2CaloLayer1 module, but with 7 monitoring elements removed, and changed to be a DQMGlobalEDAnalyzer instead of DQMOneEDAnalyzer. Monitoring elements have been moved to a dedicated CaloL1Information namespace and data structure as part of the DQMGlobalEDAnalyzer template. A duplicate of the online _cfi.py has been created for the offline module, and the overall offline L1DQM sequence L1TriggerDqmOffline_cff.py has been adjusted to add this module into the offline workflow.

PR validation:

All code compiles, and I have checked that a min bias data workflow reproduces the same histograms between the old online module and new offline module. I have also checked runTheMatrix test workflows and any failures seem due to failing to find or open remote files. As well, the PR seems to pass the basic test procedure suggested in the CMSSW PR instructions.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport

cmsbuild · 2020-10-06T09:51:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-06T09:57:48Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31678/18812

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31678/18812/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31678/18812/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-10-06T10:06:44Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-06T10:11:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31678/18816

This PR adds an extra 28KB to repository

cmsbuild · 2020-10-06T10:11:33Z

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

DQMOffline/L1Trigger

@benkrikler, @kmaeshima, @andrius-k, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2020-10-06T10:25:31Z

please test

cmsbuild · 2020-10-06T10:25:51Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-05-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9753/console Started: 2020/10/06 12:32

silviodonato · 2020-10-06T10:30:18Z

DQMOffline/L1Trigger/interface/L1TStage2CaloLayer1Offline.h

+#ifndef L1TStage2CaloLayer1Offline_H
+#define L1TStage2CaloLayer1Offline_H
+
+//change from "One" to "Global"


You can remove this kind of comments. Perhaps you can write a general comment saying that this is almost a duplicate of the online version of the L1TStage2CaloLayer1

I can go change this. Will this require the code checks and tests be restarted?

Yes, when you push the changes to your repository, the code-checks will start again automatically.
Please remove all comments similar to this one
Example:
//#include "DQMServices/Core/interface/DQMOneEDAnalyzer.h"
or
//Elements removed from online version of module. [...]

silviodonato · 2020-10-06T10:31:13Z

@aloeliger Could you explain why you are adding a new modules instead of modifying L1TStage2CaloLayer1?

aloeliger · 2020-10-06T11:00:00Z

@silviodonato There are seven luminosity block transition based monitoring elements that are not compatible with the change from DQMOneEDAnalyzer<edm::one::WatchLuminosityBlocks> to DQMGlobalEDAnalzyer<> these are:

last20Mismatches_: A monitoring element that was read back at the beginning of luminosity blocks detailing the last 20 mismatches by type (ECAL/HCAL and fine grain and feature versus other) and run, luminosity section and event.
maxEvtLinkErrorsByLumi(E/H)CAL_ and maxEvtLinkErrorsByLumi_: these 3 are monitoring elements that track the max number of link errors seen in an event for ECAL, HCAL or both for a given luminosity section. These were filled at the end of a luminosity block, and the information needed to do this would need to be shared across streams
maxEvtMismatchByLumi(E/H)CAL_ and maxEvtMismatchByLumi:_ These 3 are monitoring elements similar to the above, but for trigger mismatches.

The CaloL1 team was reluctant to change monitoring elements used for online monitoring, so for a compromise I left online monitoring unchanged and introduced a slightly changed duplicate for a multithreaded use for offline DQM.

cmsbuild · 2020-10-06T12:41:47Z

-1

Tested at: 9330df8

CMSSW: CMSSW_11_2_X_2020-10-05-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0c5b3/9753/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestDQMOfflineConfiguration0 had ERRORS

cmsbuild · 2020-10-06T12:41:50Z

Comparison job queued.

cmsbuild · 2020-10-19T14:15:07Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #31699,#31689

CMSSW_11_2_X_2020-10-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10081/console Started: 2020/10/19 16:17

cmsbuild · 2020-10-19T16:18:06Z

-1

Tested at: befefd9

CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-60df14/10081/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step5

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step5_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

140.53 step3

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step3_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

8.0 step5

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step5_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

4.53 step4

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step4_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

9.0 step4

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step4

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

136.731 step4

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step4_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

25202.0 step4

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

cmsbuild · 2020-10-19T16:18:12Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

silviodonato · 2020-10-19T16:51:19Z

The previous test was done just to check that the framework does not complain anymore about The following modules require synchronizing on LuminosityBlock boundaries of L1TStage2CaloLayer1. The test was successful.

cmsbuild · 2020-10-19T17:03:31Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #31699,#31689,#31829

CMSSW_11_2_X_2020-10-19-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10096/console Started: 2020/10/19 19:04

cmsbuild · 2020-10-19T19:11:05Z

+1
Tested at: befefd9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a187a/10096/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-19T19:11:15Z

Comparison job queued.

cmsbuild · 2020-10-19T20:26:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a187a/10096/summary.html

Comparison Summary:

You potentially added 4870 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2543640
DQMHistoTests: Total failures: 28
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543590
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -773.364 KiB( 34 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -48.369 KiB L1T/L1TStage2CaloLayer1
DQMHistoSizes: changed ( 136.731 ): -47.829 KiB L1T/L1TStage2CaloLayer1
Checked 149 log files, 22 edm output root files, 35 DQM output files

silviodonato · 2020-11-02T14:41:04Z

@aloeliger @cms-sw/dqm-l2 @cms-sw/l1-l2 what is the status of this PR? Is it ready to be merged?

aloeliger · 2020-11-02T17:08:57Z

@aloeliger I notice now that the reportSummary Map becomes orange for CaloLayer 1 and HCAL/ECAL TPG [1] due to this PR since I guess it was based on the MEs you are removing.
I would be good to modify the report so that it does not check for those plots
See what I mean here:
[1] https://tinyurl.com/y52ltpuo

@aloeliger @cms-sw/dqm-l2 @cms-sw/l1-l2 what is the status of this PR? Is it ready to be merged?

@silviodonato, @jfernan2, apologies again for my schedule, but now that Higgs2020 is done, I have talked to the CaloL1 team about a new fix that maintains the summary reports that were broken in this PR/solution. I have opened a new PR #32004 with changes exclusively to the online CaloL1 DQM that does not require this separate offline module or any changes to any configurations. At this point, I think this PR is no longer necessary, and could be safely closed in favor of #32004.

silviodonato · 2020-11-03T08:33:57Z

moved to #32004

Add new CaloL1 offline DQM module and configuration

12cf64b

cmsbuild added this to the CMSSW_11_2_X milestone Oct 6, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Oct 6, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 6, 2020

Update code formatting

9330df8

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 6, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2020

silviodonato reviewed Oct 6, 2020

View reviewed changes

cmsbuild added tests-started and removed tests-rejected labels Oct 19, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-available tests-started labels Oct 19, 2020

silviodonato mentioned this pull request Oct 19, 2020

Modules prohibiting concurrent lumis in RelVal workflows #25090

Closed

cmsbuild mentioned this pull request Oct 19, 2020

ES DQM: Enable concurrent processing of lumisections #31829

Merged

cmsbuild added tests-started and removed tests-rejected labels Oct 19, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-notrun tests-started labels Oct 19, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 19, 2020

jfernan2 mentioned this pull request Oct 20, 2020

Remove legacy dqm #31369

Closed

aloeliger mentioned this pull request Nov 2, 2020

Move CaloL1 online DQM to Global #32004

Merged

silviodonato closed this Nov 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new CaloL1 offline DQM module and configuration #31678

Add new CaloL1 offline DQM module and configuration #31678

aloeliger commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

silviodonato commented Oct 6, 2020

cmsbuild commented Oct 6, 2020 •

edited

Loading

silviodonato Oct 6, 2020

aloeliger Oct 6, 2020

silviodonato Oct 6, 2020

silviodonato commented Oct 6, 2020

aloeliger commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

silviodonato commented Oct 19, 2020

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

silviodonato commented Nov 2, 2020

aloeliger commented Nov 2, 2020 •

edited

Loading

silviodonato commented Nov 3, 2020

Add new CaloL1 offline DQM module and configuration #31678

Add new CaloL1 offline DQM module and configuration #31678

Conversation

aloeliger commented Oct 6, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

silviodonato commented Oct 6, 2020

cmsbuild commented Oct 6, 2020 • edited Loading

silviodonato Oct 6, 2020

Choose a reason for hiding this comment

aloeliger Oct 6, 2020

Choose a reason for hiding this comment

silviodonato Oct 6, 2020

Choose a reason for hiding this comment

silviodonato commented Oct 6, 2020

aloeliger commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 6, 2020

cmsbuild commented Oct 19, 2020 • edited Loading

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

silviodonato commented Oct 19, 2020

cmsbuild commented Oct 19, 2020 • edited Loading

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

cmsbuild commented Oct 19, 2020

silviodonato commented Nov 2, 2020

aloeliger commented Nov 2, 2020 • edited Loading

silviodonato commented Nov 3, 2020

cmsbuild commented Oct 6, 2020 •

edited

Loading

cmsbuild commented Oct 19, 2020 •

edited

Loading

cmsbuild commented Oct 19, 2020 •

edited

Loading

aloeliger commented Nov 2, 2020 •

edited

Loading