Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 IT RechHit DQM and Validation modules #31666

Merged
merged 12 commits into from
Oct 13, 2020

Conversation

sroychow
Copy link
Contributor

@sroychow sroychow commented Oct 5, 2020

PR description:

This PR adds the DQM and Validation modules for Phase2 IT RecHits. Along with that, a couple of utility headers are added containing common functions used by all Phase2 tracker DQM, Validation modules.

PR validation:

This PR was validated using Phase2 wfs - 23234.0, 30634.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18782

  • This PR adds an extra 32KB to repository

  • Found files with invalid states:

    • Validation/SiTrackerPhase2V/interface/Phase2ValidationUtil.h:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18783

  • This PR adds an extra 32KB to repository

  • Found files with invalid states:

    • Validation/SiTrackerPhase2V/interface/Phase2ValidationUtil.h:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

DQM/SiTrackerPhase2
Validation/SiTrackerPhase2V

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@arossi83, @sroychow this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented Oct 5, 2020

@emiglior @skinnari FYI


namespace Phase2TkUtil {

std::string getITHistoId(uint32_t det_id, const TrackerTopology* tTopo) {
Copy link
Contributor

@mmusich mmusich Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sroychow am I wrong or this (and the other method getOTHistoId below), can be used as a drop-in replacement here:

std::string Phase2TrackerValidateDigi::getHistoId(uint32_t det_id, const TrackerTopology* tTopo, bool flag) {

and here:

std::string Phase2TrackerMonitorDigi::getHistoId(uint32_t det_id, const TrackerTopology* tTopo, bool flag) {

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich yes this is intended to replace all getHistoId calls in the digi module as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. So this will be done in another separate PR?

DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.cc Outdated Show resolved Hide resolved
// Get the geometry
edm::ESHandle<TrackerGeometry> geomHandle;
iSetup.get<TrackerDigiGeometryRecord>().get(geomHandle);
const TrackerGeometry* tkGeom = &(*geomHandle);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could ported to use esconsumes.

DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.cc Outdated Show resolved Hide resolved
DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.cc Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18978

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

@cmsbuild
Copy link
Contributor

Pull request #31666 was updated. @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Oct 12, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 49ac5cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36d268/9889/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36d268/9889/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 295085.376 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 37575.132 KiB TrackerPhase2ITRecHit/EndCap_Side2
  • DQMHistoSizes: changed ( 23234.0,... ): 37575.132 KiB TrackerPhase2ITRecHit/EndCap_Side1
  • DQMHistoSizes: changed ( 23234.0,... ): 16699.668 KiB TrackerPhase2ITRecHit/Barrel
  • DQMHistoSizes: changed ( 23234.0,... ): 1771.939 KiB TrackerPhase2ITRecHit/Global_Position_RZ_IT_endcap
  • DQMHistoSizes: changed ( 23234.0,... ): 1771.939 KiB TrackerPhase2ITRecHit/Global_Position_RZ_IT_barrel
  • DQMHistoSizes: changed ( 23234.0,... ): 1415.689 KiB TrackerPhase2ITRecHit/Global_Position_XY_IT_endcap
  • DQMHistoSizes: changed ( 23234.0,... ): 1415.689 KiB TrackerPhase2ITRecHit/Global_Position_XY_IT_barrel
  • DQMHistoSizes: changed ( 23234.0,... ): 55.978 KiB TrackerPhase2ITRecHitV/EndCap_Side2
  • DQMHistoSizes: changed ( 23234.0,... ): 55.978 KiB TrackerPhase2ITRecHitV/EndCap_Side1
  • DQMHistoSizes: changed ( 23234.0,... ): 24.410 KiB TrackerPhase2ITRecHitV/Barrel
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 13, 2020

+1

@cmsbuild cmsbuild merged commit bf0befb into cms-sw:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants