-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2 IT RechHit DQM and Validation modules #31666
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18782
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18783 |
A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master. It involves the following packages: DQM/SiTrackerPhase2 @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
|
||
namespace Phase2TkUtil { | ||
|
||
std::string getITHistoId(uint32_t det_id, const TrackerTopology* tTopo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sroychow am I wrong or this (and the other method getOTHistoId
below), can be used as a drop-in replacement here:
std::string Phase2TrackerValidateDigi::getHistoId(uint32_t det_id, const TrackerTopology* tTopo, bool flag) { |
and here:
std::string Phase2TrackerMonitorDigi::getHistoId(uint32_t det_id, const TrackerTopology* tTopo, bool flag) { |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich yes this is intended to replace all getHistoId calls in the digi module as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. So this will be done in another separate PR?
// Get the geometry | ||
edm::ESHandle<TrackerGeometry> geomHandle; | ||
iSetup.get<TrackerDigiGeometryRecord>().get(geomHandle); | ||
const TrackerGeometry* tkGeom = &(*geomHandle); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could ported to use esconsumes.
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18978
|
Pull request #31666 was updated. @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds the DQM and Validation modules for Phase2 IT RecHits. Along with that, a couple of utility headers are added containing common functions used by all Phase2 tracker DQM, Validation modules.
PR validation:
This PR was validated using Phase2 wfs - 23234.0, 30634.0.
if this PR is a backport please specify the original PR and why you need to backport that PR:
NA