-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially fix CLCT position bias after CCLUT (CCLUT-8) #31656
Partially fix CLCT position bias after CCLUT (CCLUT-8) #31656
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31656/18757
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DataFormats/CSCDigi @cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The CCLUT algorithm is not enabled yet, so there shouldn't be changes in any of the workflows. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31656/18761
|
I had a closer look at the CLCT bending resolution. Preliminary plots (not for publication) are attached. It seems that for the position LUT the Anyway it would be good to check the bending resolutions for highly displaced muons and see if it looks similar. |
Pull request #31656 was updated. @benkrikler, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch can you please check and sign again. |
For non-ME1/1 there is an bending bias of about -0.1, which I have yet to sort out. |
Look-up tables in cms-data/L1Trigger-CSCTriggerPrimitives#3 were updated with the correct slope definition. |
urgent |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The tests are being triggered in jenkins.
|
@rekovic @silviodonato Thanks. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
PR description:
In recent studies, a bias was found in the 1/2-strip, 1/4-strip and 1/8-strip positions of about 0.17. The bias has now been eliminated for the 1/2 position. A bias of < 0.1 strip remains for the 1/4 and 1/8 strip positions (this may be due to how we define the 1/n-strip position: center or middle). New LUTs provided here: cms-data/L1Trigger-CSCTriggerPrimitives#3.
PR validation:
Tested with
/RelValSingleMuPt10/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW
and/RelValSingleMuFlatPt2To100/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW
Most recent presentation summarizing the results https://indico.cern.ch/event/965106/contributions/4062917/attachments/2122267/3572271/CSCResolutionNewPatterns_SD_20201014.pdf
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
@tahuang1991 Please pick-up the new .mem files from https://github.com/cms-data/L1Trigger-CSCTriggerPrimitives.