-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dqmEnvSiPixelQuality from DQMEventInfo to DQMHarvestingMetadata #31609
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31609/18669
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiPixelQuality @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
assign dqm since the change is purely a change of DQM tools. The alca signature will follow immediately after the DQM sign-off. |
New categories assigned: dqm @jfernan2,@andrius-k,@fioriNTU,@kmaeshima,@ErnestaP you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Allows to display on GUI metadata information for the SiPixel Bad Components PCL workflow.
This piece was leftover from the migration at #28821.
PR validation:
Produced a test file using wf 1040.0 and injected to private local GUI:
without this PR:
with this PR:
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is needed.