Include the HF filters used in heavy ions using struct in the MiniAOD content #31602

denerslemos · 2020-09-27T22:59:40Z

Dear All,

This PR is an update of the previous one: #30810, and already include the changes requested. As expected, the results obtained using struct was exactly the same as using vectors, even in the case of MiniAOD size. The results can be found in this set of slides (from previous PR):

https://www.dropbox.com/s/susuzaanbk3jb3h/HIHFFilter.pdf?dl=0

The studies above was made in 103X, and was also tested in 112X using "runTheMatrix.py -l limited -i all --ibeos", in special workflow 159. The versions 103X and 112X returns exactly the same results on the tests. On this new version I have checked in the exactly the same way on 112X.

@mandrenguyen @pjwinnetou @FHead

Best,

Dener Lemos

Summarizing the request:

This PR is made to include the HF event filters in the Heavy Ions miniAOD workflow. This is expected to be included only for the eras "pp_on_AA_2018" and "pp_on_PbPb_run3". Since the towerMaker collection is not saved in miniAOD this filters need be stored in the miniAOD content. To include that filters, a EDProducer was created to run on PAT and store a struct with 4 integers which each of them has the minimum number of towers above some threshold between the two HF sides (std::min(nTowerHF+,nTowerHF-)), which means:

numMinHFTowers2 = N of minimum HF towers above 2 GeV
numMinHFTowers3 = N of minimum HF towers above 3 GeV
numMinHFTowers4 = N of minimum HF towers above 4 GeV
numMinHFTowers5 = N of minimum HF towers above 5 GeV

cmsbuild · 2020-09-27T23:00:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-27T23:06:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31602/18653

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): HeavyIon Reaction Plane MiniAOD #31129, Switch to heavy-ion jets in HI miniAOD #30898
- File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): HeavyIon Reaction Plane MiniAOD #31129

cmsbuild · 2020-09-27T23:07:12Z

A new Pull Request was created by @denerslemos (Dener Lemos) for master.

It involves the following packages:

DataFormats/HeavyIonEvent
PhysicsTools/PatAlgos
RecoHI/HiCentralityAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @yslai, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @dgulhan, @jdolen, @ferencek, @mandrenguyen, @yetkinyilmaz, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @jazzitup, @JyothsnaKomaragiri, @yenjie, @kurtejung, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-09-28T10:00:52Z

please test

cmsbuild · 2020-09-28T10:01:10Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9610/console Started: 2020/09/28 12:03

cmsbuild · 2020-09-28T11:25:43Z

+1
Tested at: 058dbef
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547df9/9610/summary.html
CMSSW: CMSSW_11_2_X_2020-09-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-28T11:25:46Z

Comparison job queued.

cmsbuild · 2020-09-28T14:28:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547df9/9610/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2539438
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2539415
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

jpata

Overall, looks good! I had some comments inline (click "resolve" once you have addressed them).

DataFormats/HeavyIonEvent/interface/HFFilterStruct.h

DataFormats/HeavyIonEvent/src/classes_def.xml

RecoHI/HiCentralityAlgos/plugins/HiHFFilterProducer.cc

jpata · 2020-10-07T07:20:12Z

+reconstruction

introduces HF filters for heavy ion MINIAOD
new product reco::HFFilterInfo is created and stored in the output only for HI workflows
file size and event processing time increases are negligible, as reported in the original PR and confirmed independently in my tests on WF 158.1

silviodonato · 2020-10-07T16:46:58Z

please test workflows 140.57, 159.0, 159.1, 310.0

cmsbuild · 2020-10-07T16:47:20Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 159.0,159.1,140.57,310.0
CMSSW_11_2_X_2020-10-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9780/console Started: 2020/10/07 18:49

cmsbuild · 2020-10-07T18:14:50Z

+1
Tested at: e67d14c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547df9/9780/summary.html
CMSSW: CMSSW_11_2_X_2020-10-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-07T18:14:52Z

Comparison job queued.

cmsbuild · 2020-10-07T19:38:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-547df9/9780/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-547df9/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-547df9/159.1_QCD_Pt_80_120_14_HI_2021+QCD_Pt_80_120_14_HI_2021+DIGIHI2021PPRECO+RECOHI2021PPRECO+HARVESTHI2021PPRECO
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-547df9/310.0_Pyquen_GammaJet_pt20_2760GeV_2021+Pyquen_GammaJet_pt20_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

santocch · 2020-10-08T12:28:58Z

+1

cmsbuild · 2020-10-08T12:29:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-09T00:27:13Z

+1

Include the HF filters for heavy ions in the MiniAOD content

058dbef

cmsbuild added this to the CMSSW_11_2_X milestone Sep 27, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 27, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2020

jpata suggested changes Sep 29, 2020

View reviewed changes

Include the suggested changes

f5397ec

cmsbuild removed code-checks-approved comparison-available tests-approved labels Sep 29, 2020

cmsbuild mentioned this pull request Oct 6, 2020

Adding vertex recovery step for 2018 heavy ion miniAOD production. #31676

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 7, 2020

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-available tests-approved tests-pending labels Oct 7, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 7, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 7, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Oct 8, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 9, 2020

cmsbuild merged commit d7632eb into cms-sw:master Oct 9, 2020

silviodonato mentioned this pull request Oct 22, 2020

GEM unpacker: bugfix and more cross checks #31863

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include the HF filters used in heavy ions using struct in the MiniAOD content #31602

Include the HF filters used in heavy ions using struct in the MiniAOD content #31602

denerslemos commented Sep 27, 2020 •

edited

Loading

cmsbuild commented Sep 27, 2020

cmsbuild commented Sep 27, 2020

cmsbuild commented Sep 27, 2020

perrotta commented Sep 28, 2020

cmsbuild commented Sep 28, 2020 •

edited

Loading

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

jpata left a comment

jpata commented Oct 7, 2020

silviodonato commented Oct 7, 2020

cmsbuild commented Oct 7, 2020 •

edited

Loading

cmsbuild commented Oct 7, 2020

cmsbuild commented Oct 7, 2020

cmsbuild commented Oct 7, 2020

santocch commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

qliphy commented Oct 9, 2020

Include the HF filters used in heavy ions using struct in the MiniAOD content #31602

Include the HF filters used in heavy ions using struct in the MiniAOD content #31602

Conversation

denerslemos commented Sep 27, 2020 • edited Loading

cmsbuild commented Sep 27, 2020

cmsbuild commented Sep 27, 2020

cmsbuild commented Sep 27, 2020

perrotta commented Sep 28, 2020

cmsbuild commented Sep 28, 2020 • edited Loading

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

cmsbuild commented Sep 28, 2020

jpata left a comment

Choose a reason for hiding this comment

jpata commented Oct 7, 2020

silviodonato commented Oct 7, 2020

cmsbuild commented Oct 7, 2020 • edited Loading

cmsbuild commented Oct 7, 2020

cmsbuild commented Oct 7, 2020

cmsbuild commented Oct 7, 2020

santocch commented Oct 8, 2020

cmsbuild commented Oct 8, 2020

qliphy commented Oct 9, 2020

denerslemos commented Sep 27, 2020 •

edited

Loading

cmsbuild commented Sep 28, 2020 •

edited

Loading

cmsbuild commented Oct 7, 2020 •

edited

Loading