-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop type specs in RecoBTag #31538
drop type specs in RecoBTag #31538
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
from RecoBTag.Combined.pfDeepCSVJetTags_cfi import pfDeepCSVJetTags | ||
|
||
caloDeepCSVJetTags = pfDeepCSVJetTags.clone(src = cms.InputTag('caloDeepCSVTagInfos')) | ||
caloDeepCSVJetTags = pfDeepCSVJetTags.clone(src = 'caloDeepCSVTagInfos') |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,13 +12,17 @@ | |
) | ||
|
||
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel | ||
phase1Pixel.toModify(pfDeepCSVJetTags, NNConfig = cms.FileInPath('RecoBTag/Combined/data/DeepCSV_PhaseI.json')) | ||
phase1Pixel.toModify(pfDeepCSVJetTags, checkSVForDefaults = cms.bool(True)) | ||
phase1Pixel.toModify(pfDeepCSVJetTags, meanPadding = cms.bool(True)) | ||
phase1Pixel.toModify(pfDeepCSVJetTags, toAdd = cms.PSet()) | ||
phase1Pixel.toModify(pfDeepCSVJetTags, | ||
NNConfig = cms.FileInPath('RecoBTag/Combined/data/DeepCSV_PhaseI.json'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Indeed, thank you @silviodonato There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Finalization in #31568 (submitted now before forgetting it) |
||
checkSVForDefaults = True, | ||
meanPadding = True, | ||
toAdd = cms.PSet() | ||
) | ||
|
||
from Configuration.Eras.Modifier_phase2_common_cff import phase2_common | ||
phase2_common.toModify(pfDeepCSVJetTags, NNConfig = cms.FileInPath('RecoBTag/Combined/data/DeepCSV_PhaseII.json')) | ||
phase2_common.toModify(pfDeepCSVJetTags, checkSVForDefaults = cms.bool(True)) | ||
phase2_common.toModify(pfDeepCSVJetTags, meanPadding = cms.bool(True)) | ||
phase2_common.toModify(pfDeepCSVJetTags, toAdd = cms.PSet()) | ||
phase2_common.toModify(pfDeepCSVJetTags, | ||
NNConfig = cms.FileInPath('RecoBTag/Combined/data/DeepCSV_PhaseII.json'), | ||
checkSVForDefaults = True, | ||
meanPadding = True, | ||
toAdd = cms.PSet() | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you also drop the
FileInPath
type specifiers?