Fix for era modifiers used to rerun anti-e MVA tauID for NanoAOD

[mbluj]

PR description:

This PR fixes way in which era modifiers are used to switch between different versions of anti-e MVA tauID for NanoAOD. Namely, with setup updated in this PR the tau ID with the most recent (2018) training is rerun as a part of nanoAOD sequences for (explicitly listed) past nanoAOD eras, while the tauID with an old (2015) training is read from input miniAOD. For other (new) eras, conversely: the tauID with the old training is rerun, while the one with the new training is read from input miniAOD.

This PR reverts changes introduced in 064713f and follows discussion in #31065 (comment)

PR validation:

Tested with relevant nanoAOD workflows.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31302/18033

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-31-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9022/console Started: 2020/08/31 19:34

[cmsbuild]

+1
Tested at: 721c785
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b22d7/9022/summary.html
CMSSW: CMSSW_11_2_X_2020-08-31-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b22d7/9022/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

+xpog
fix the switch of previous eras
validation is here #31065 (comment)

[mariadalfonso]

type bug-fix

[qliphy]

+1

[mrodozov]

is this a fix for the two relvals that started failing few days ago :
1329.1 and 136.7722 ?

[mbluj]

is this a fix for the two relvals that started failing few days ago :
1329.1 and 136.7722 ?

It was not intention of this PR. Actually, I do not know nothing about those failures; are they related to taus in nanoAOD?

[qliphy]

is this a fix for the two relvals that started failing few days ago :
1329.1 and 136.7722 ?

The fix for 1329.1 and 136.6622 is #31303

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.