-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed generator/Geant4 interface for PPS #31270
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31270/17951
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/Generators @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
@mundim , please, try this out. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 differences are expected |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@civanch could you spend some words about the expected differences (it might be useful also for the future validation of 11_2_0_pre6 @cms-sw/pdmv-l2 )? Are they expected only at large eta? I see many plots changed. Thank you |
@silviodonato , I have extended the description. plots changed due to change of histories. |
Thanks @civanch. If I understand correctly, we expect changes only in simulated objects because the simulation is extended up to PPS/ZDC and the history changes. |
@silviodonato , unfortunately when we spend few or less random numbers in some event, then the history in the next event may be completely different. I see statistical agreement in this plot but no regression. |
PR description:
Generator/Geant4 interface is fixed:
transport scattered protons moved to from IR to PPS station and Geant4 get these protons in front of PPS or ZDC. Actual implementation of Hector transport is outside this PR, here only interface is provided
These modifications are needed for PPS simulation. Due to change in very forward direction simulation histories are affected, so no regression is expected
PR validation:
private
if this PR is a backport please specify the original PR and why you need to backport that PR: not now