add centrality bin to HI miniAOD

[mandrenguyen]

PR description:

This PR add the centrality bin producer to the HI miniAOD workflow.
This producer has long been in cmssw, and was once part of the reconstruction.
It consumes the tag that was added in #30930

PR validation:

Tested with workflow 158.01

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30934/17350

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add the HF Filters in Heavy Ions miniAOD #30810, Switch to heavy-ion jets in HI miniAOD #30898
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add the HF Filters in Heavy Ions miniAOD #30810

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8350/console Started: 2020/07/28 14:32

[slava77]

@mandrenguyen
please provide some event size estimates for the added product(s).
unless the product is optimally compressible, some assessment of possible reduction in size would be useful (reduced precision or unused variables).

[slava77]

please remind the reason why centralityBin was removed from reco in #18684 . Was there a problem with the producer at run time (if so, was it removed)?

[mandrenguyen]

please remind the reason why centralityBin was removed from reco in #18684 . Was there a problem with the producer at run time (if so, was it removed)?

The centrality bin was originally in the reconstruction. However, since one needs to see the full data to have the corresponding calibration, we always ended up overwriting the produced centrality bins. At some point we were running HI reco using pp GTs, and the code was crashing since the tag was not available. So we simply removed it. For miniAOD, we think we'll often be running in such a way that the calibrations can be added to the GT for production.

[cmsbuild]

The code-checks are being triggered in jenkins.

[mandrenguyen]

I just added a single integer per event, which is the actual output to this module. The previously added collection is the input, which we would like to keep as well.
To answer Slava's question, these two collections amount to 0.2% of the miniAOD size for wf 158.01.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30934/17355

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add the HF Filters in Heavy Ions miniAOD #30810, Switch to heavy-ion jets in HI miniAOD #30898
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Add the HF Filters in Heavy Ions miniAOD #30810

[mandrenguyen]

if edm::stream is simpler/more familiar, I think that it can be acceptable

That was easier, thanks!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30934/17488

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544, Switch to heavy-ion jets in HI miniAOD #30898
  • File PhysicsTools/PatAlgos/python/slimming/slimming_cff.py modified in PR(s): [RFC] Store TrackExtra, TrackingRecHits, and SiPixel/StripClusters for muons in AOD+MINIAOD #30544

[cmsbuild]

Pull request #30934 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[mandrenguyen]

Can someone give me a 'please test', please?

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8501/console Started: 2020/08/03 06:06

[cmsbuild]

+1
Tested at: 3aa1044
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14ef2b/8501/summary.html
CMSSW: CMSSW_11_2_X_2020-08-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14ef2b/8501/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525448
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525399
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 144 log files, 17 edm output root files, 34 DQM output files

[jpata]

+1

• tests pass
• adds a single int to HI miniAOD workflows
• output is filled with meaningful values
• technical update to CentralityBinProducer from edm::EDProducer -> edm::stream::EDProducer as requested

[silviodonato]

merge
@santocch

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.