-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
106X backport of #30738 (Use dxy sign of GSF track instead of IPTools for pat::Electron) #30892
Conversation
A new Pull Request was created by @afiqaize (Afiq Anuar) for CMSSW_10_6_X. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #30738 |
@@ -91,6 +91,7 @@ PATElectronProducer::PATElectronProducer(const edm::ParameterSet & iConfig) : | |||
embedHighLevelSelection_(iConfig.getParameter<bool>("embedHighLevelSelection")), | |||
beamLineToken_(consumes<reco::BeamSpot>(iConfig.getParameter<edm::InputTag>("beamLineSrc"))), | |||
pvToken_(mayConsume<std::vector<reco::Vertex> >(iConfig.getParameter<edm::InputTag>("pvSrc"))), | |||
getdBFromTrack_(iConfig.getParameter<bool>("getdBFromTrack")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not present in the master version!
Please clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the default value in the fillDescription() method: then this PR is ready to be backported
@@ -1131,6 +1132,7 @@ void PATElectronProducer::fillDescriptions(edm::ConfigurationDescriptions & desc | |||
)->setComment("input with high level selection"); | |||
iDesc.addNode( edm::ParameterDescription<edm::InputTag>("pvSrc", edm::InputTag(), true) | |||
)->setComment("input with high level selection"); | |||
iDesc.add<bool>("getdBFromTrack", true)->setComment("switch IP2D computation to use the GSF track instead of IPTools"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default must be "false" in the backport
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged. |
PR description:
Backport #30738 in the same way as #29537, with extra switch to activate the fix, and the same era modifier to activate said switch.
PR validation:
The same validation as #30738.
if this PR is a backport please specify the original PR and why you need to backport that P R:
#30738 for use in UL reminiAOD.